Fix read and replay daemons death detection #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A multiprocessing empty queue was causing an infinite wait in the daemon main loop if the read_daemon and/or replay_daemon were killed, preventing the issue detection. The main process and the eventual remaining child process were staying running while the replication was no longer working from a global point of view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A
multiprocessingempty queue was causing an infinite wait in the daemon main loop if the read_daemon and/or replay_daemon were killed, preventing the issue detection and any remediation. The main process and the eventual remaining child process were staying running while the replication was no longer working from a global point of view.Not digged into why the queue is empty, perhaps it deserves another investigation in another issue or PR?