Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: ananke will always show recent posts on index #794

Closed
Klaas- opened this issue Nov 17, 2024 · 2 comments · Fixed by #795
Closed

bug: ananke will always show recent posts on index #794

Klaas- opened this issue Nov 17, 2024 · 2 comments · Fixed by #795
Assignees
@davidsneighbour

Comments

@Klaas-
Copy link
Contributor

Klaas- commented Nov 17, 2024

This seems to be a regression, either because of the recent ananke changes or because of changes in hugo.
Setting recent_posts_number = 0 will no longer disable showing recent posts on index.

I tested a little and I think this is because {{ $n_posts := $.Param "recent_posts_number" | default 3 }} will default to 3 if recent_posts_number is 0.

Expected Behavior

Ability to disable recent posts on index

Current Behavior

not possible to disable recent posts on index

Possible Solution

Add a parameter to toggle showing recent posts

Steps to Reproduce

  1. set recent_posts_number = 0
  2. observe recent posts are still being shown

The bigger picture (we need context)

Hugo Config

@Klaas- Klaas- mentioned this issue Nov 17, 2024
Merged
@davidsneighbour
Copy link
Collaborator

I think $.Param got slightly demoted a while back. The last paragraph here is the solution. I would suggest to use the solution offered there instead of hard coding a default into the template?

@davidsneighbour
Copy link
Collaborator

Ignore my comment ;) I did not look at the PR before commenting, and my comment was focused only on the $.Param issue, which is not related to the PR at all.

davidsneighbour pushed a commit that referenced this issue Dec 2, 2024
@Klaas-
theme(fix): add show_recent_posts parameter to stop showing recent po…
b06949e 
…sts on index (#795)

<!---

Add the issue number that is discussed and fixed by this PR (In the form
`Closes #123`). If this PR doesn't fix an issue, remove the line below.
This will
also lead to us not treating this PR as an important one. It might be
closed
without a review.

If there is no issue associated with this PR and you are not a
maintainer of
this repository, your PR might be closed without a review.

-->

Closes #794

You can no longer set `recent_posts_number = 0` because in current hugo
versions `{{ $n_posts := $.Param "recent_posts_number" | default 3 }}`
will default to three if recent_posts_number is 0. This used to work a
couple of versions back, I am assuming this is not a regression but
rather wanted behavior in hugo -- so I introduce a new parameter
(boolean) `show_recent_posts` to enable(default) or disable recent posts
on index.



<!---

Explain what this PR does and what existing problem it solves. If this
PR is a
work in progress, please prefix the title with [WIP].

-->

<!--

Make sure that the code is readable and well-documented. If you have
added new
functionality, please add the necessary documentation.
If testing of the new functionality is possible, please add tests.

-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidsneighbour davidsneighbour

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davidsneighbour @Klaas-