Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licence #3

Open
thebrightspark opened this issue Nov 12, 2023 · 5 comments
Open

Licence #3

thebrightspark opened this issue Nov 12, 2023 · 5 comments

Comments

@thebrightspark
Copy link
Contributor

Hey, I was looking to see if I could potentially update this to 1.20.x, however I've noticed there's no licence on this repo?

I'd suggest adding one (if you don't intend this to be ARR), but would you be open to a PR and to publish the mod for 1.20.x? No idea if I'll even manage a port, but thought I'd find out this first 😅

Thanks!

@Rushmead
Copy link
Member

Hi there, definitely open to a PR for porting the mod. Assume the license is MIT, I'll pop an update to the repo when I get a chance.

@thebrightspark
Copy link
Contributor Author

Thanks, appreciate it!

I've been having a preliminary look, but which branch would be ideal to base off of? main or sp/cables?

@Rushmead
Copy link
Member

No worries!

Great question, sp/cables is very close to being complete it just needs some tidying work. I don't remember what the status of main is at the moment. I wonder if my changes to sp/cables will easily rebase on to main?

@thebrightspark
Copy link
Contributor Author

thebrightspark commented Nov 15, 2023

On my fork it appears it can be merged in without issue

image

Oops wrong repo target, but same thing anyways 🙂

@Rushmead
Copy link
Member

Ah awesome! We have a discord that you're welcome to join if you interested to discussing specific bits further though unfortunately I've hadn't much time nor motivation to keep on top of it in the past few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants