Manifest collision on v13.4.0

[vladica86]

Hey all,

After upgrading to v13.4.0 build is failing since I have manifest collision between facebook 18 and play-services-measurement-api (likely coming from firebase). I'm on bare Expo, but I think this may be an issue in non-expo projects as well.

* What went wrong:
Execution failed for task ':app:processReleaseMainManifest'.
> Manifest merger failed : Attribute property#android.adservices.AD_SERVICES_CONFIG@resource value=(@xml/ga_ad_services_config) from [com.google.android.gms:play-services-measurement-api:22.1.2] AndroidManifest.xml:32:13-58
  	is also present at [com.facebook.android:facebook-core:18.0.0] AndroidManifest.xml:57:13-55 value=(@xml/ad_services_config)

Any idea on how this can be resolved?

Thanks

[mikehardy]

Probably by a basic search of the web

https://duckduckgo.com/?q=Manifest+merger+failed+%3A+Attribute+property%23android.adservices.AD_SERVICES_CONFIG&t=brave&ia=web

and an application of the discovered solution

https://stackoverflow.com/questions/78350965/manifest-merger-failed-attribute-propertyandroid-adservices-ad-services-confi

https://stackoverflow.com/a/78362880/9910298

How's it go when you apply the tools:replace for that item to your AndroidManifest.xml ?

[vladica86]

If it was so basic I wouldn't bother to ask...it doesn't resolve it. Nvm, I'll figure it out

[mikehardy]

You wouldn't believe what people ask, thus I must ask first as well. My question was sincere:

How's it go when you apply the tools:replace for that item to your AndroidManifest.xml ?

Shocking that does not work in fact - if there is a collision but you request the manifest merge process replace one with the other, that is the method to deconflict. I would strongly suspect something wrong with the test methodology used to check if that worked or not because really - tools:replace is custom built for this purpose

I'm not speaking out of ignorance here, I also maintain react-native-google-mobile-ads and we had to deal with the same collision between it and @react-native-firebase/analytics (which I also maintain...)

I reviewed the PR that closed the issue, and released it.

• [🐛] [Android] Build fails in bare Expo project when integrating react-native-google-mobile-ads with @react-native-firebase/analytics invertase/react-native-google-mobile-ads#657
• fix: resolve AndroidManifest conflict for AD_SERVICES_CONFIG invertase/react-native-google-mobile-ads#660

A similar PR may be useful here?

But it will be based on tools:replace...

[mikehardy]

The critical piece missing in the test is that the AndroidManifest.xml here, in this repo, is the one that likely needs the change.

[TheRogue76]

The suggested fix does work, but this Repo's example app is not really connected to the rest of the code so it is a bit of a pain in the ass to test. Wrote the PR. Let me know your thoughts @mikehardy #600

[mikehardy]

metro did not used to handle symlinks making example apps a pain in the ass to make and maintain, including this one. yarn dev-copy I think does the trick. Anyway, the PR looks great, in process of merge and release now. I appreciate you taking the time and especially the testing to make sure it worked @TheRogue76 - thanks

[TheRogue76]

Yeah, understandable, i lost count of how many times i had to deal with this. Appreciate your work as always Mike. ❤️