Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of pydeps in CI to reject introduction of new import cycles? #219

Open
hartwork opened this issue Apr 20, 2024 · 3 comments
Open

Use of pydeps in CI to reject introduction of new import cycles? #219

hartwork opened this issue Apr 20, 2024 · 3 comments

Comments

@hartwork
Copy link

Hi!

Thanks for sharing pydeps as software libre! 🙏

I would love to build CI that rejects introduction of new import cycles, and I'm not yet sure how I would do that with pydeps if possible. Has this been done before? Any ideas or pointers?

Thanks and best, Sebastian

@hartwork
Copy link
Author

Update: I have come up with something like that by myself in the mean time: https://github.com/hartwork/no-cyclic-imports .

@thebjorn
Copy link
Owner

Hi @hartwork Because of your license I can't look at your source code, but if you're interested in providing a PR I'll be happy to merge it.

@hartwork
Copy link
Author

@thebjorn it took me a moment to really understand your reply, but I think I got it now. We could still team up on getting #197 fixed in pydeps, and I have no problem contributing new code to this project under the current BSD-2 license. Maybe a quick voice call on the topic would be best, my profile has my e-mail address if you're interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants