-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle more PHPStan type edge-cases #487
Conversation
After thecodingmachine#486 thecodingmachine#487 and thecodingmachine#488 are merged, running `./.devcontainer/build.sh` produces this output, which contains a couple of years worth of updates - and from there, the github cronjob _should_ submit incremental updates as PRs automatically
per #488 (comment) the tests of this PR should now succeed - as the other 2 dependent PRs have been merged - right ? |
@staabm getting close, though it seems I prematurely assumed that all the PHP versions had the same test failures, when actually 8.1 and 8.2-8.4 had different failures >.< But at least the divergence is small enough now, so I'll try to keep the fixes in this PR... |
Awesome |
@@ -112,7 +112,11 @@ public function testVoid(): void | |||
{ | |||
$param = new PhpStanType(''); | |||
$this->assertEquals('', $param->getDocBlockType()); | |||
$this->assertEquals('', $param->getSignatureType()); | |||
if (PHP_VERSION_ID >= 80200) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we need to fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I'm not sure exactly why php8.1 is generating different output here D: It should probably be investigated at least
Less crashing in code generation \o/