From 452f21215869e1324692289b2e2a70b3a4de226f Mon Sep 17 00:00:00 2001 From: Ewoud Kohl van Wijngaarden Date: Mon, 14 Mar 2022 14:40:47 +0100 Subject: [PATCH] Convert to theforeman/actions for Ruby tests These reusable actions remove a lot of duplication. It also respects the matrix configuration provided in Foreman itself, meaning it will automatically detect the supported Ruby and NodeJS versions. --- .github/workflows/ruby_tests.yml | 72 ++++++-------------------------- 1 file changed, 12 insertions(+), 60 deletions(-) diff --git a/.github/workflows/ruby_tests.yml b/.github/workflows/ruby_tests.yml index c076dfc4d..9599f0d9f 100644 --- a/.github/workflows/ruby_tests.yml +++ b/.github/workflows/ruby_tests.yml @@ -1,67 +1,19 @@ name: Ruby Testing -on: [pull_request] -env: - RAILS_ENV: test - DATABASE_URL: postgresql://postgres:@localhost/test - DATABASE_CLEANER_ALLOW_REMOTE_DATABASE_URL: true - BUNDLE_WITHOUT: "journald:development:console:mysql2:sqlite:libvirt" + +on: pull_request + concurrency: - group: ${{ github.workflow }}-${{ github.ref }} + group: ${{ github.ref_name }}-${{ github.workflow }} cancel-in-progress: true + jobs: rubocop: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - name: Setup Ruby - uses: ruby/setup-ruby@v1 - with: - ruby-version: 2.7 - bundler-cache: true - - name: Run rubocop - run: bundle exec rubocop + name: Rubocop + uses: theforeman/actions/.github/workflows/rubocop.yml@v0 + test_ruby: - runs-on: ubuntu-latest + name: Ruby needs: rubocop - timeout-minutes: 15 - services: - postgres: - image: postgres:12.1 - ports: ['5432:5432'] - options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5 - strategy: - fail-fast: false - matrix: - foreman-core-branch: [develop] - ruby-version: [2.7] - node-version: [12] - steps: - - run: sudo apt-get update - - run: sudo apt-get install build-essential libcurl4-openssl-dev zlib1g-dev libpq-dev - - uses: actions/checkout@v2 - with: - repository: theforeman/foreman - ref: ${{ matrix.foreman-core-branch }} - - uses: actions/checkout@v2 - with: - path: foreman-tasks - - name: Setup Plugin in Foreman - run: | - echo "gem 'foreman-tasks', path: './foreman-tasks'" > bundler.d/foreman-tasks.local.rb - echo "gem 'sqlite3'" >> bundler.d/foreman-tasks.local.rb - - name: Setup Ruby - uses: ruby/setup-ruby@v1 - with: - ruby-version: ${{ matrix.ruby-version }} - bundler-cache: true - - name: Setup Node - uses: actions/setup-node@v1 - with: - node-version: ${{ matrix.node-version }} - - name: Prepare test env - run: | - bundle exec rake db:create - bundle exec rake db:migrate - - name: Run plugin tests - run: | - bundle exec rake test:foreman_tasks + uses: theforeman/actions/.github/workflows/foreman_plugin.yml@v0 + with: + plugin: foreman-tasks