Issues with HostPuppetFacet do not trigger a rollback or removal of the partially configured host

[darkphoenix]

Summary

When something goes wrong configuring Puppet for a newly created host (in our case, due to puppetlabs/puppetserver!2901), this causes the host to not be configured any further by Foreman, but it does not trigger a rollback either, leaving it in a half created state and necessitating a manual deletion before the name can be reused.

Expected Behavior

When issues occur in the configuration of a host, the process is aborted cleanly and rolled back, allowing the name to be reused.

Actual Behavior

The entire process is aborted and error 422 returned. The new host is left in an incompletely configured state and must be manually cleaned up.

Versions

foreman_puppet 7.0.0 on Foreman 3.11.4