-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use candlepin::repo in testing with a version fact #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: in theforeman/puppet-pulpcore#309 (comment) I'm updating the stack and found out that I may need to work on a proper solution to input the test matrix in gha-puppet. voxpupuli/gha-puppet#6 tracks that effort.
@@ -15,15 +19,6 @@ | |||
} | |||
} | |||
|
|||
# Defaults to staging, for release, use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was a time when nightly was broken for a long time, so we switched to staging and forgot to change it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - and this effectively switches it back.
I've opened #245 with a slightly different implementation. I've also finished the BEAKER_FACTER work in gha-puppet which means you can use the regular reusable workflows. Now I need to wrap up the integration in foreman-installer-modulesync. There's just a very weird issue in puppet-pulpcore left. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather avoid switching from a reusable workflow to a manual one and back. Currently investigating the last failure, but overall I think the work is ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That context helps.
No description provided.