Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use candlepin::repo in testing with a version fact #244

Closed
wants to merge 1 commit into from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Oct 9, 2023

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: in theforeman/puppet-pulpcore#309 (comment) I'm updating the stack and found out that I may need to work on a proper solution to input the test matrix in gha-puppet. voxpupuli/gha-puppet#6 tracks that effort.

@@ -15,15 +19,6 @@
}
}

# Defaults to staging, for release, use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was a time when nightly was broken for a long time, so we switched to staging and forgot to change it back.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - and this effectively switches it back.

@ekohl
Copy link
Member

ekohl commented Oct 12, 2023

I've opened #245 with a slightly different implementation. I've also finished the BEAKER_FACTER work in gha-puppet which means you can use the regular reusable workflows. Now I need to wrap up the integration in foreman-installer-modulesync. There's just a very weird issue in puppet-pulpcore left.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather avoid switching from a reusable workflow to a manual one and back. Currently investigating the last failure, but overall I think the work is ready.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That context helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants