Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add db_extra_options parameter #1195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmaes
Copy link

@dmaes dmaes commented Nov 13, 2024

This PR adds a db_extra_options parameter, to allow adding custom parameters in the database.yml config.

Fixes #1194

@dmaes
Copy link
Author

dmaes commented Jan 7, 2025

@ekohl @evgeni anything still missing to get this reviewed and merged?

@dmaes dmaes force-pushed the db_extra_options branch from cbd76b2 to 98ed32c Compare January 9, 2025 14:19
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit slow getting back from the holiday break.

templates/database.yml.epp Outdated Show resolved Hide resolved
templates/database.yml.epp Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
@dmaes
Copy link
Author

dmaes commented Jan 20, 2025

@ekohl thanks for the feedback, I implemented the suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow more database.yml settings
2 participants