Create branches and/or tags corresponding to releases of new versions of the gem

[dmitri-d]

I don't have commit access and can't help with this.

[timogoebel]

The github group https://github.com/orgs/theforeman/teams/proxy-ad-realm should be used for this. An org admin has to set that up.

As a side note: We should probably switch to be using semver for this plugin to be consistent with the rest.

Speaking of commit access: Can we make sure, that the gem on rubygems.org also has more than one owner? Just to reduce the bus factor.

And last, but not least: A huge thanks to the both of you. It really thrills me to see, how things come together here. This is solid community work.

[ekohl]

Looks like the access should be set up, but no tags have been pushed. @martencassel do you still have the tags locally and can push them? Can you also have a look at sharing the access to https://rubygems.org/gems/smart_proxy_realm_ad_plugin so multiple people can push a new gem?

[martencassel]

Hello,
Please ping me if you want owner access to the rubygem at https://rubygems.org/gems/smart_proxy_realm_ad_plugin,
and i will add you as an owner.

Today i updated radcli to a more recent version of realmad-adcli, see here: https://github.com/martencassel/radcli/releases/tag/v1.1.0

Regards
// Marten

[ekohl]

We have https://rubygems.org/profiles/theforeman where we add shared gems. It would be good to add it to the gems. Let me know if you need help with that, but I think it's gem owner GEM -a EMAIL but maybe you can also pass a username instead of EMAIL.

[ekohl]

@martencassel checking back on this, I see the gem ownership hasn't been added. Any chance you could get around to it? I can email you the address.

[martencassel]

I have a "little" mfa issue with rubygems atm but when its sorted out i can fix it.
Or better can we use a organizal account related to foreman instead if thats available ? Fo you have that ?

[ekohl]

https://rubygems.org/profiles/theforeman is an "organization" account. AFAIK sadly Rubygems doesn't really have proper orgs, just shared users. Because it's shared, we don't have 2FA on it. I'm not sure if there's a better way.

[martencassel]

@ekohl Hi, i've now added theforeman as a owner to smart_proxy_realm_ad_plugin.

Another thing, this plugin depends on a library, https://rubygems.org/gems/radcli. Would it be of use to add it to theforeman org as well ?
radcli depends on adcli C library, so it's just a ruby wrapper to this library.
In the future we might have to bump the adcli library version,
https://github.com/martencassel/radcli/blob/master/ext/lib/libadcli.a

[ekohl]

@ekohl Hi, i've now added theforeman as a owner to smart_proxy_realm_ad_plugin.

Thanks!

Another thing, this plugin depends on a library, https://rubygems.org/gems/radcli. Would it be of use to add it to theforeman org as well ?

I wouldn't mind adding the Foreman org to the gem, but I wonder if we should then also transfer the git repo to theforeman GH org.

radcli depends on adcli C library, so it's just a ruby wrapper to this library.
In the future we might have to bump the adcli library version,
https://github.com/martencassel/radcli/blob/master/ext/lib/libadcli.a

I wonder if you can somehow build against a system version rather than bundling a version. adcli is also in Fedora and EL8 so that would allow relying on the OS vendor for security updates. Perhaps a separate discussion.

[martencassel]

@ekohl Hi, i've now added theforeman as a owner to smart_proxy_realm_ad_plugin.

Thanks!

Another thing, this plugin depends on a library, https://rubygems.org/gems/radcli. Would it be of use to add it to theforeman org as well ?

I wouldn't mind adding the Foreman org to the gem, but I wonder if we should then also transfer the git repo to theforeman GH org.

Sure we can do that !

radcli depends on adcli C library, so it's just a ruby wrapper to this library.
In the future we might have to bump the adcli library version,
https://github.com/martencassel/radcli/blob/master/ext/lib/libadcli.a

I wonder if you can somehow build against a system version rather than bundling a version. adcli is also in Fedora and EL8 so that would allow relying on the OS vendor for security updates. Perhaps a separate discussion.

The adcli rpm does not include libadcli to be used, this library is compiled into the adcli binary in the distribution rpm for adcli. I don't think libadcli is available as an rpm. It would be nice if they could ship adcli as a developer package.
I checked here: https://src.fedoraproject.org/rpms/adcli/blob/f33/f/adcli.spec
Seems that adcli-devel could have been available at one point, but not anymore.