Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_args: support numeric and boolean values #279

Open
pat-s opened this issue Nov 18, 2024 · 5 comments
Open

build_args: support numeric and boolean values #279

pat-s opened this issue Nov 18, 2024 · 5 comments

Comments

@pat-s
Copy link
Contributor

pat-s commented Nov 18, 2024

Currently, build_args requires values to be set as characters. Using numeric/boolean values results in empty values in the final build call.

@xoxys
Copy link
Member

xoxys commented Nov 19, 2024

A bit confused about this one. Plugins get all settings via env var from the server. As env vars are untyped/strings I don't see how this could be a plugin issue 🤔

@pat-s
Copy link
Contributor Author

pat-s commented Nov 19, 2024

Previously I had build_args defined as a list, e.g. - FOO=var, now it is a map (FOO: "var"). Maybe there is some coercing going on? (didn't do any inspection yet)

@xoxys
Copy link
Member

xoxys commented Dec 5, 2024

I'm still a bit confused 😅 Yes build_args is now a map. You have to use it this way:

build_args:
  FOO: "bar"
  OTHER: 199
  BAR:
    from_secret: baz

In this example, using OTHER: 199 is not working for you?

@pat-s
Copy link
Contributor Author

pat-s commented Dec 5, 2024

Correct. Only "OTHER: "199" works.

@xoxys
Copy link
Member

xoxys commented Dec 5, 2024

Ok will give it a test but I have the feeling this is a server issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants