Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how config and certificates are being read #15

Open
3 tasks
thegodenage opened this issue Apr 6, 2024 · 2 comments
Open
3 tasks

Refactor how config and certificates are being read #15

thegodenage opened this issue Apr 6, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@thegodenage
Copy link
Owner

Context

Currently the config and the certificates are embedded in the main.go. It is good approach for now but it would be nice to refactor it, in order to make it simpler to set up and edit during the development.

TODO

  • Refactor how the config and certificates are being read
  • Add unit tests for the changes
  • Fix other tests accordingly (if it's needed)

AC

  • There is a new approach of reading the configs and certificates
  • There are unit tests made for the changes and others are fixed

How to test?

  • The pipeline should succeed
  • Unit tests should pass
  • WAF should read configs and certificates
@thegodenage thegodenage added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 6, 2024
@wrik0
Copy link

wrik0 commented Apr 11, 2024

@cebilon123 I'm picking this up. I'm assuming you'd like the options for a .env file use as well as a load from os environment as well. I'd like to add validation for certs, the PEM keys during the initial load itself rather than the invocation during proxy.Server.Start(). LMK if you approve.

@thegodenage
Copy link
Owner Author

thegodenage commented Apr 12, 2024

Go on. This needs a love, great idea with the validation and env reading. I was thinking about scaling it up, and the kubernates would be a way to go, but this needs to be researched more (so the env would be needed in the future. You can write some handy abstractions because we would use it in the collector as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants