Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHD #43

Closed
Mateus109 opened this issue Nov 16, 2021 · 2 comments · Fixed by #44
Closed

UHD #43

Mateus109 opened this issue Nov 16, 2021 · 2 comments · Fixed by #44

Comments

@Mateus109
Copy link

Bing wallpapers are now available in UHD 5935 × 3338 (e.g. https://www.bing.com/th?id=OHR.HogwartsExpress_EN-GB7641570883_UHD.jpg) and also 3840x2160.
thejandroman added a commit that referenced this issue Jan 18, 2022
@thejandroman
Update and simplify script
fc6034d 
After moving to Arch I decided to give this forgotten script a try. It didn't work. It was also very complicated. URL parsing from JSON is a crazy thing to try to do in a bash script. I don't have a Mac to test these changes on but hopefully everything still works. There were a number of overlapping PRs over the years that made it into this revision. I've tried to add credit to the original PRs where applicable.

Summary of changes:

1. Merge latest and boost code paths (From @Lyncredible in #39)
2. Use https for all requests if -s (From @Lyncredible in #39)
3. Update URL patterns  (From @Lyncredible in #39, @microdog in #36, @nitrogear in #23)
4. Add UHD support (fixes #43)
5. Remove contributing.json as it wasn't used anymore
@thejandroman thejandroman mentioned this issue Jan 18, 2022
Merged
@thejandroman
Copy link
Owner

UHD was added in #44 but I wasn't able to figure out how to add 3840x2160 support. Do you have a sample URL?

@Mateus109
Copy link
Author

The image sizes for the _UHD variants all seems a bit random, perhaps they're the original photos and Microsoft have just stuck _UHD on the end. e.g. today's image is 5889 × 3313, yesterdays was 7348 × 4133, Sunday's 6108 × 3436, etc.
I'm grabbing them with:
$match = []; if (!preg_match('/<urlBase>(.+)<\/urlBase>/', $xml, $match)) { die(); } $url = 'http://www.bing.com' . $match[1] . '_UHD.jpg';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

0.5.0 thejandroman/bing-wallpaper
2 participants
@thejandroman @Mateus109