Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter tests are failing #3

Open
sergenikov opened this issue Mar 28, 2017 · 0 comments
Open

Adapter tests are failing #3

sergenikov opened this issue Mar 28, 2017 · 0 comments

Comments

@sergenikov
Copy link

sergenikov commented Mar 28, 2017

Hi @thejsj,

I wanted to use the module, but saw that none of the tests are passing (both on Travis and my local machine). Since there aren't any pull requests that could've broken it, do you know if this adapter can be out of date with RethinkDB or socket.io-adapter itself? All tests fail because of the exceeded timeout and no messages are received. Only the db and the table are created, but they are always empty. If I use this adapter to store sockets in RethinkDB - nothing is stored there as well.
Thanks in advance for any input.

Update: the culprit seems to be the remove_undefined function: right now it's recursive and runs infinitely. Did not have the time to debug further yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant