Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Article resolvers return both Article and Draft type objects #2906

Closed
1 task done
gary02 opened this issue Nov 2, 2022 · 1 comment · Fixed by #2959
Closed
1 task done

Article resolvers return both Article and Draft type objects #2906

gary02 opened this issue Nov 2, 2022 · 1 comment · Fixed by #2959
Assignees
@gary02
Labels
bug Something isn't working

Comments

@gary02
Copy link
Contributor

gary02 commented Nov 2, 2022 •
edited
Loading

Tasks

  • Article resolvers return both Article and Draft , at the same time most Article fields' resolvers assume that their parents are Draft

References
@devformatters devformatters changed the title Article resolvers return both Article and Drafttype objects Article resolvers return both Article and Draft type objects Nov 2, 2022
@devformatters devformatters added the bug Something isn't working label Nov 2, 2022
@devformatters devformatters moved this from Pending to Upcoming in Sprint Board (sunsetting) Nov 2, 2022
@robertu7 robertu7 mentioned this issue Nov 16, 2022
Closed
4 tasks
@devformatters devformatters moved this from Upcoming to Select For Development in Sprint Board (sunsetting) Nov 16, 2022
@gary02 gary02 moved this from Select For Development to In Progress in Sprint Board (sunsetting) Nov 21, 2022
@gary02 gary02 linked a pull request Nov 22, 2022 that will close this issue
fix DraftToArticleResolver resolver #2959
Merged
@gary02
Copy link
Contributor Author

gary02 commented Nov 22, 2022

  • root-resovler
  • editArticle
  • toggleASubscribeArticle
  • appreciateArticle
  • readArticle
  • toggleArticleRecommend
  • updateArticleState
  • Topic.latestAricle
  • Topic.articles
  • CircleContentAnalytics.Public
  • CircleContentAnalytics.Paywall
  • ArticleNotice.target
  • ArticleActicleNotice.target
  • ArticleActicleNotice.article
  • ArticleTagNotice.article
  • Appreciation
  • Chapter.articles
  • ReadHistory
  • UserAddArticleTagActivity
  • UserPublishArticleActivity
  • ArticleRecommendationActivity.nodes
  • ResponseEdge
  • Transaction.target
  • Recommendation.readTagsArticle
  • Recommendation.newest
  • Recommendation.hottest
  • Recommendation.icymi
  • User.articles
  • User.commentedArticles
  • User.subscription
  • OSS.articles
  • Draft.article
  • Draft.collection
  • Circle.works
  • Tag.articles
  • Article.collectedBy
  • Article.collection
  • Article.relatedArticles
  • Article.relatedDonationAricles

All resolvers return draft correctly, except Draft.article

@gary02 gary02 moved this from In Progress to Review In Progress in Sprint Board (sunsetting) Nov 22, 2022
@gary02 gary02 moved this from Review In Progress to Approved in Sprint Board (sunsetting) Nov 22, 2022
Repository owner moved this from Approved to Review In Progress in Sprint Board (sunsetting) Nov 23, 2022
@devformatters devformatters moved this from Review In Progress to Approved in Sprint Board (sunsetting) Nov 23, 2022
@gary02 gary02 moved this from Approved to Done in Sprint Board (sunsetting) Nov 24, 2022
@devformatters devformatters moved this from Done to Archived Issues in Sprint Board (sunsetting) Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gary02 gary02

Labels
bug Something isn't working
Projects
No open projects
Sprint Board (sunsetting)
Status: Archived Issues
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix DraftToArticleResolver resolver thematters/matters-server
2 participants
@gary02 @devformatters