Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise tag API #4220

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Revise tag API #4220

merged 2 commits into from
Nov 18, 2024

Conversation

gitwoz
Copy link
Contributor

@gitwoz gitwoz commented Nov 14, 2024 •
edited
Loading

Changes

  • Add Tag.recommendedAuthors;
  • Revise aglo for Tag.recommended, User.recommendation.tags;
  • Add alias for tag: toggleBookmarkTag, toggleBookmarkArticle, User.bookmarked;
  • Remove User.subscribers;

Note

  • Base branch: feat/deprecate-tag-management

@gitwoz gitwoz requested a review from a team as a code owner November 14, 2024 05:32
@gitwoz gitwoz linked an issue Nov 14, 2024 that may be closed by this pull request
Revise algo for tag feeds #4204
Open
3 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 48.68421% with 39 lines in your changes missing coverage. Please review.

Project coverage is 61.73%. Comparing base (03557f3) to head (20b4234).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
src/connectors/tagService.ts 23.33% 21 Missing and 2 partials ⚠️
src/queries/article/tag/articles.ts 0.00% 8 Missing ⚠️
src/queries/article/tag/recommendedAuthors.ts 42.85% 3 Missing and 1 partial ⚠️
...migrations/20241112112619_create_tag_stats_view.js 83.33% 1 Missing ⚠️
...ations/20241112165500_create_article_stats_view.js 80.00% 1 Missing ⚠️
...grations/20241113094622_create_tag_hottest_view.js 80.00% 1 Missing ⚠️
src/mutations/article/editArticle.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4220      +/-   ##
===========================================
+ Coverage    60.73%   61.73%   +0.99%     
===========================================
  Files          956      935      -21     
  Lines        18850    18208     -642     
  Branches      3505     3326     -179     
===========================================
- Hits         11449    11241     -208     
+ Misses        6692     6323     -369     
+ Partials       709      644      -65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gitwoz gitwoz changed the title WIP: Revise tag API Revise tag API Nov 15, 2024
@gitwoz gitwoz changed the base branch from develop to feat/deprecate-tag-management November 15, 2024 03:59
@pauljusti pauljusti merged commit dd42a36 into feat/deprecate-tag-management Nov 18, 2024
1 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/tag-aglo branch November 18, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kechicode Kechicode Kechicode approved these changes

@pauljusti pauljusti Awaiting requested review from pauljusti

@zeckli zeckli Awaiting requested review from zeckli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revise algo for tag feeds
3 participants
@gitwoz @Kechicode @pauljusti