Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(npm): drop legacy peer deps #4171

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

lizhineng
Copy link
Contributor

Removing the flag doesn't cause any peer dependency issues, so it's safe to drop it now.

@lizhineng lizhineng requested a review from a team as a code owner September 5, 2024 02:29
gary02
gary02 previously approved these changes Sep 5, 2024
@gary02 gary02 dismissed their stale review September 5, 2024 04:15

Please rebase the branch

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.86%. Comparing base (de9ea2f) to head (d1706f8).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4171      +/-   ##
===========================================
- Coverage    60.89%   60.86%   -0.04%     
===========================================
  Files          952      952              
  Lines        18749    18739      -10     
  Branches      3407     3403       -4     
===========================================
- Hits         11417    11405      -12     
- Misses        7279     7282       +3     
+ Partials        53       52       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants