You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
The current version extends AppenderSkeleton, which synchronously sends events to Sentry. If the Sentry server has any latency, this can cause the application code to block. If we extended BufferingAppenderSkeleton instead, it would append asynchronously and we would inherit any of its buffering options.
I'm happy to do a PR on this, but I'd like your opinion on whether we should add a separate BufferingSentryAppender or just change the existing one to extend BufferingAppenderSkeleton.
The text was updated successfully, but these errors were encountered:
Sounds like a worthwhile improvement to me, although hopefully the original authors will get involved (I had a PR accepted a few months back so they may yet return to this). I've also been using my own fork to keep dependencies updated..
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The current version extends AppenderSkeleton, which synchronously sends events to Sentry. If the Sentry server has any latency, this can cause the application code to block. If we extended BufferingAppenderSkeleton instead, it would append asynchronously and we would inherit any of its buffering options.
I'm happy to do a PR on this, but I'd like your opinion on whether we should add a separate BufferingSentryAppender or just change the existing one to extend BufferingAppenderSkeleton.
The text was updated successfully, but these errors were encountered: