Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Support buffering #8

Open
richardszalay opened this issue Aug 20, 2015 · 2 comments
Open

Support buffering #8

richardszalay opened this issue Aug 20, 2015 · 2 comments

Comments

@richardszalay
Copy link

The current version extends AppenderSkeleton, which synchronously sends events to Sentry. If the Sentry server has any latency, this can cause the application code to block. If we extended BufferingAppenderSkeleton instead, it would append asynchronously and we would inherit any of its buffering options.

I'm happy to do a PR on this, but I'd like your opinion on whether we should add a separate BufferingSentryAppender or just change the existing one to extend BufferingAppenderSkeleton.

@lukehutton
Copy link

I don't think this project is under active development, as I read from one of the comments. I'd happily accept your pull request :)

@rogersillito
Copy link
Contributor

Sounds like a worthwhile improvement to me, although hopefully the original authors will get involved (I had a PR accepted a few months back so they may yet return to this). I've also been using my own fork to keep dependencies updated..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants