Skip to content
This repository has been archived by the owner on Apr 4, 2020. It is now read-only.

New sub-package: emoji #19

Closed
colinodell opened this issue Mar 15, 2019 · 5 comments
Closed

New sub-package: emoji #19

colinodell opened this issue Mar 15, 2019 · 5 comments
Assignees

Comments

@colinodell
Copy link
Member

A community extension already exists for emoji, but it's tightly coupled to Laravel and Github: https://packagist.org/packages/alt-three/emoji

Let's create a generic version which renders :emoji: input as Unicode emoji characters (and maybe bundle in some custom renderers which can render them as images?)

@colinodell colinodell self-assigned this Mar 15, 2019
@GrahamCampbell
Copy link
Member

It's not tightly coupled to laravel (apart from the require in the composer, which could be removed), and it's not coupled to github either actually - the parser just expects some abstract repository: https://github.com/AltThree/Emoji/blob/v7.0.0/src/EmojiParser.php.

@GrahamCampbell
Copy link
Member

All of the things are meshed together in https://github.com/AltThree/Emoji/blob/v7.0.0/src/EmojiServiceProvider.php, and the rest of the package is decoupled.

@GrahamCampbell
Copy link
Member

I'd be interested in getting emoji build right into the official extras package. The latest version is now at https://github.com/CachetHQ/Emoji, but has not been tagged yet. I'd like to be able to abandon both https://github.com/CachetHQ/Emoji and https://github.com/CachetHQ/Twitter in favour of official packages.


Maybe we should chat about this in private. Can I instant message you somewhere?

@colinodell
Copy link
Member Author

Hi Graham,

That sounds good to me! Feel free to DM me on Twitter or Google Hangouts (or whatever Google is calling their messaging platform these days)

@colinodell
Copy link
Member Author

Moving this to thephpleague/commonmark#421

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants