-
Notifications
You must be signed in to change notification settings - Fork 106
/
ToDo
53 lines (32 loc) · 2.75 KB
/
ToDo
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
Outside input appreciated:
Deal with variables that have spaces, e.g.
survfit( Surv(time, status) ~ `bad idea for a name`, data=yourdata)
I never use such things so it has been low on my list, but some others do. I think that the heart of the issue is in the strata() function, and may just need smarter use of text manipulation tools when building the strata label. This overlaps with issue 232
Add include.lowest option to tcut(), to make it align with cut().
confint method for coxph objects that uses profile likelihood. Standard +-1.96*se intervals acually work very well for the Cox model, so I don't expect it to matter a lot, but it is a user request
Depricate survConcordance. The replacement concordance function handles a wider range of models and has a superior variance. But there are a bunch of packages that use it, and they will need coaxing/help with the conversion.
coxph still returns the Splus style assign attribute. It's overdue to change.
If you fit a coxph model fit <- coxph(Surv(time, status) ~ x1 + x2, data1)
then predict(fit, newdata=data2), x1 is a factor, and the levels of the factor for data2 have values not in data1, this should give an clear error message. This hasn't been checked out for all newdata cases, i.e., predict, survfit, and concordance. Also test cases for when they are valid, but either a subset or in a different order.
-----
Bugs:
cox.zph for a model with robust variance has incorrect confidence intervals on curves. This is a result of a change over a year ago; the math behind this is still a bit opaque to me.
And see the list of open issues
------
Harder tasks:
Predict method for multi-state coxph model. The computational core is I think mostly simple, i.e., stacker() is needed to rebuild the X matrix. Less clear is what a user would want the output to look like, which needs some thought.
residuals.survfit for curves from a multi-state Cox model. This is needed for variance estimates. (Hard, I think)
Proper variance for yates survival curve. Think about a discussion with the emmeans package, whether they could inherit some of what yates tries to do.
Reliability models vignette.
Rewrite the penalized models code.
Add the design of the survival library document to vignettes
Add likeihood displacement residuals?
Cook and Lawless, Multistate models for life history data, page 104, just above
section 3.5.2. States that
$\hat \theta - \hat\theta_{(i)} \approx V U_i$
where $V$ is the Cox model variance.
This is my formula for the dfbeta residuals. They also state that
$LD_i = 2(loglik(\theta) - loglik(\theta_{(i)}) = U'_i V U_i $
This appears to be Han Van H's likelihood displacement residual and would lead
to the cross-validated log-likelhood? They are talking about parametric
models though.