Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solo enum in the proto file case a bad field type name #180

Closed
CorrM opened this issue Nov 13, 2022 · 4 comments
Closed

Solo enum in the proto file case a bad field type name #180

CorrM opened this issue Nov 13, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@CorrM
Copy link

CorrM commented Nov 13, 2022

When i have one enum(maybe more than one too) on the whole file that will case a bad filed type name.

After checking src i think the bug would be in that function field.getType

Sorry im so busy this days, i can't submit PR

Bug showcase:

// update-prop-message.ts
// enumUpdatePropChangeEnum MUST to be UpdatePropChangeEnum
set change_type(value: dependency_1.enumUpdatePropChangeEnum) {
        pb_1.Message.setField(this, 1, value);
}

Files to raise the bug:

// update-prop-change-enum.proto
syntax = "proto3";

package MY_PACKAGE.enum;

enum UpdatePropChangeEnum
{
  UpdatePropChange_NONE = 0;
  CHANGE = 1;
}
// update-prop-message.proto
syntax = "proto3";

package MY_PACKAGE.message;

import "update-prop-change-enum.proto";

message UpdatePropMessage
{
  MY_PACKAGE.enum.UpdatePropChangeEnum change_type = 1;
}
@thesayyn thesayyn added the bug Something isn't working label Jan 9, 2023
@CorrM
Copy link
Author

CorrM commented Sep 28, 2023

any update ?

@thesayyn
Copy link
Owner

Hey, no. Please feel free to send a PR.

@CorrM
Copy link
Author

CorrM commented Sep 28, 2023

I never uses bazel before, and development section in readme is are poor (at least for me) sorry,
if you can show me how to setup the dev environment i could fix it. <3

@thesayyn
Copy link
Owner

thesayyn commented Mar 1, 2024

This is fixed in the rust implementation; See #255

@thesayyn thesayyn closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants