Skip to content

Commit

Permalink
travis: Use $(...) instead ... in bash scripts
Browse files Browse the repository at this point in the history
It's encouraged to use version with $(...).
    Backtick command substitution `...` is legacy
    syntax with several issues.

   1. It has a series of undefined behaviors related to quoting in POSIX.
   2. It imposes a custom escaping mode with surprising results.
   3. It's exceptionally hard to nest.

   ~https://github.com/koalaman/shellcheck/wiki/SC2006

Signed-off-by: Karol Trzcinski <[email protected]>
  • Loading branch information
ktrzcinx authored and lgirdwood committed Sep 24, 2020
1 parent e67d68e commit e29baaa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ jobs:
before_install: docker pull thesofproject/sof && docker tag thesofproject/sof sof
script:
- echo -e '#!/bin/bash\nmkdir build && cd build && cmake .. && make -Werror -Wall -Wmissing-prototypes -Wimplicit-fallthrough=3 -Wpointer-arith' > build.sh && chmod +x build.sh
- docker run -i -t -v `pwd`:/home/sof/work/sof.git --user `id -u` sof ./build.sh
- docker run -i -t -v $(pwd):/home/sof/work/sof.git --user $(id -u) sof ./build.sh

0 comments on commit e29baaa

Please sign in to comment.