From e29baaa8b9dc90fcff9b8914b1d0ac2768474b54 Mon Sep 17 00:00:00 2001 From: Karol Trzcinski Date: Wed, 23 Sep 2020 07:59:39 +0200 Subject: [PATCH] travis: Use $(...) instead `...` in bash scripts It's encouraged to use version with $(...). Backtick command substitution `...` is legacy syntax with several issues. 1. It has a series of undefined behaviors related to quoting in POSIX. 2. It imposes a custom escaping mode with surprising results. 3. It's exceptionally hard to nest. ~https://github.com/koalaman/shellcheck/wiki/SC2006 Signed-off-by: Karol Trzcinski --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 7966559..e266ad5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -12,4 +12,4 @@ jobs: before_install: docker pull thesofproject/sof && docker tag thesofproject/sof sof script: - echo -e '#!/bin/bash\nmkdir build && cd build && cmake .. && make -Werror -Wall -Wmissing-prototypes -Wimplicit-fallthrough=3 -Wpointer-arith' > build.sh && chmod +x build.sh - - docker run -i -t -v `pwd`:/home/sof/work/sof.git --user `id -u` sof ./build.sh \ No newline at end of file + - docker run -i -t -v $(pwd):/home/sof/work/sof.git --user $(id -u) sof ./build.sh