Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thesofproject/rimage
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fbea59358d06ffa86645cdf4ce0996e352742eb5
Choose a base ref
...
head repository: thesofproject/rimage
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 469102a8f6052ce6a374b870ea945a84d04c3b1a
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 30, 2023

  1. config/lnl.toml: drop now invalid signed_pkg.partition_usage

    Fixes commit fbea593 ("rimage: mtl: fix key slot setup based on imr
    type") which broke LNL compilation like this:
    
    ```
    error: 1 unparsed keys left in 'signed_pkg'
    error: key 'signed_pkg' parsing error
    ```
    
    Of course LNL is never going to be released on this stable-v2.7 branch
    but this one-line fix is just the smallest and simplest fix to keep
    everything building and green. It also keeps everything simple and
    consistent.
    
    This commit does not change the final image (compared to before rimage
    commit fbea593) because the default value is now 0x20 + IMR type.
    
    Fixes are normally submitted to the main branch first and then cherry
    picked to stable branches. However fbea593 has been made in
    stable-v2.7 first so make this change also in stable-v2.7 first for
    consistency.
    
    Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    marc-hb committed Oct 30, 2023
    Copy the full SHA
    469102a View commit details
Showing with 0 additions and 1 deletion.
  1. +0 −1 config/lnl.toml
1 change: 0 additions & 1 deletion config/lnl.toml
Original file line number Diff line number Diff line change
@@ -44,7 +44,6 @@ length = "0x0" # calculated by rimage

[signed_pkg]
name = "ADSP"
partition_usage = "0x23"
[[signed_pkg.module]]
name = "ADSP.met"