Config: Add RTC_AEC to TGL. TGL-H, and LNL #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds same RTC_AEC module entry as added earlier to config/mtl.toml. The purpose is enable testing the component in other platforms. Signed-off-by: Seppo Ingalsuo <[email protected]>
lgirdwood
approved these changes
Oct 5, 2023
RanderWang
approved these changes
Oct 10, 2023
|
Please resubmit directly to SOF repo (rimage moved to sof/tools/rimage). |
|
Ok, let me keep this open still |
kv2019i
requested changes
Oct 11, 2023
|
With RTC_AEC added, it can give people impression that the module is part of the FW build now. |
|
@singalsu you can very easily move these commits to the main sof repo, see how at: |
There is no worry, the Kconfig is "default n", so there is no risk that a mock-up feature would end up to build by default. I think we should have rimage toml for everything. Then including component to build is just kconfig change. Otherwise there's a big patching effort find out and add all the toml files details. |
|
New patch is in thesofproject/sof#8315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds same RTC_AEC module entry as added earlier to config/mtl.toml. The purpose is enable testing the component in other platforms.