Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtl: remove smart amp config in basefw #185

Merged

Conversation

RanderWang
Copy link
Contributor

Smart amp will be a loadable module.

Smart amp will be a loadable module.

Signed-off-by: Rander Wang <[email protected]>
@RanderWang
Copy link
Contributor Author

@kv2019i is this branch correct ? thanks!

@lgirdwood
Copy link
Member

@RanderWang @kv2019i should we be pushing PRs here now that @marc-hb has upstreamed into sof repo ? I can park this repo if ready now ?

@mengdonglin
Copy link
Contributor

mengdonglin commented Oct 16, 2023

@RanderWang @kv2019i should we be pushing PRs here now that @marc-hb has upstreamed into sof repo ? I can park this repo if ready now ?

@lgirdwood This is for making dummy smart amp loadable for mtl-006 only, as mtl-006 is still using this separate rimage. This is not for SOF main branch where loadable module support is not available.

@pjdobrowolski
Copy link
Contributor

You can load any loadable module on sof main only if it use standard native system service.

Copy link
Contributor

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the SOF mtl-006 branch should use a new rimage mtl-006 branch, not the rimage main branch.

@mengdonglin
Copy link
Contributor

I think the SOF mtl-006 branch should use a new rimage mtl-006 branch, not the rimage main branch.

@marc-hb The rimage mtl-006 branch already exists for previous mtl-006 FW release. Current PR is for https://github.com/thesofproject/rimage/tree/mtl-006-drop-stable, not the main rimage branch of rimage.

@lgirdwood lgirdwood merged commit ce857f1 into thesofproject:mtl-006-drop-stable Oct 18, 2023
4 checks passed
@marc-hb
Copy link
Contributor

marc-hb commented Oct 18, 2023

My bad sorry. I keep missing the target branch all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants