[stable-v2.7] config/lnl.toml: drop now invalid signed_pkg.partition_usage #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes commit fbea593 ("rimage: mtl: fix key slot setup based on imr type") which broke LNL compilation like this: ``` error: 1 unparsed keys left in 'signed_pkg' error: key 'signed_pkg' parsing error ``` Of course LNL is never going to be released on this stable-v2.7 branch but this one-line fix is just the smallest and simplest fix to keep everything building and green. It also keeps everything simple and consistent. This commit does not change the final image (compared to before rimage commit fbea593) because the default value is now 0x20 + IMR type. Fixes are normally submitted to the main branch first and then cherry picked to stable branches. However fbea593 has been made in stable-v2.7 first so make this change also in stable-v2.7 first for consistency. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
added a commit
to marc-hb/sof
that referenced
this pull request
Oct 27, 2023
|
Successfully tested in sof/stable-v2.7 https://github.com/thesofproject/sof/actions/runs/6672554043/job/18136695980?pr=8410 Github Actions all green thanks to this. |
marc-hb
changed the title
marc-hb
requested review from
plbossart,
lgirdwood,
RanderWang,
abonislawski,
fredoh9,
kv2019i,
aiChaoSONG and
jxstelter
RanderWang
approved these changes
Oct 30, 2023
lgirdwood
approved these changes
Oct 30, 2023
abonislawski
approved these changes
Oct 30, 2023
marc-hb
added a commit
to marc-hb/sof
that referenced
this pull request
Oct 30, 2023
Update rimage to version 469102a8f6052ce6a374b870ea945a84d04c3b1a Only one new commit to fix Github Actions: config/lnl.toml: drop now invalid signed_pkg.partition_usage See thesofproject/rimage#190 Signed-off-by: Marc Herbert <[email protected]>
kv2019i
pushed a commit
to thesofproject/sof
that referenced
this pull request
Oct 31, 2023
Update rimage to version 469102a8f6052ce6a374b870ea945a84d04c3b1a Only one new commit to fix Github Actions: config/lnl.toml: drop now invalid signed_pkg.partition_usage See thesofproject/rimage#190 Signed-off-by: Marc Herbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes commit fbea593 ("rimage: mtl: fix key slot setup based on imr type") which broke LNL compilation like this:
Of course LNL is never going to be released on this stable-v2.7 branch but this one-line fix is just the smallest and simplest fix to keep everything building and green. It also keeps everything simple and consistent.
This commit does not change the final image (compared to before rimage commit fbea593) because the default value is now 0x20 + IMR type.
Fixes are normally submitted to the main branch first and then cherry picked to stable branches. However fbea593 has been made in stable-v2.7 first so make this change also in stable-v2.7 first for consistency.