loadable module: define a new bit in fw_image_flags #191
Conversation
config/mtl.toml
Outdated
| @@ -55,6 +55,7 @@ base_offset = "0x2000" | |||
| [fw_desc.header] | |||
| name = "ADSPFW" | |||
| load_offset = "0x40000" | |||
| fw_image_flags = "0x12" | |||
There was a problem hiding this comment.
Can you add a comment that 0x12 is BASE_FW+CONTEXT_IS_NOT_SAVED or something like this?
The bit 4 is set to force driver reload library on d3 exit Signed-off-by: Rander Wang <[email protected]>
RanderWang
force-pushed
the
reload_library
branch
from
9dcb7bf to
3d57706
Compare
|
add more comments |
|
The ability to survive D3 is the property of FW, not the FW image binary (a file). It is known at the FW build time, therefore adding it to the binaries making this information instantly available to the driver looks like a good idea. But then it should be added consistently to all the binaries, otherwise it might be interpreted like a different behavior of individual binaries (base_fw/libs) while this defines a behavior of the FW related to all loaded binaries. So, it requires extra maintenance and looking from this perspective, adding this property to the IPC4 FW_CONFIG parameter of the Base FW looks like a simpler solution to maintain (adding more overhead at the run-time though) unless we agree to (a) develop an asymmetric Extended Manifest containing properties valid for the Base FW only or (b) agree that extra maintenance costs are OK or (c) agree that the flag is valid in case of the base_fw binary only and extra "if" in the driver's code is OK. |
|
Sorry for adding another twist to an already complex topic but... why is this submitted directly to Also, there is now a single git repo on the main branch which makes everything more direct, faster and easier to test (then later cherry-pick code already tested well to separate git repos) |
|
no need |
The bit 4 is set to force driver reload library on d3 exit.
It is a prototype for validation with mtl-006 branch so I use hard core. We need to add a new feature that toml can decode macro definition like
fw_image_flag = BASE_FW | RELOAD_LIBRARY
Kernel PR thesofproject/linux#4669 depends on this rimage update.