Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special instrumentation silently fails when instrumenting newly added functions #168

Open
ejrgilbert opened this issue Sep 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ejrgilbert
Copy link
Collaborator

We need to either disable instrumentation on newly added functions OR make sure it works in all cases (not just before_at(0)).

To reproduce (silently disregards special instrumentation when encoding):

let global_map_init_fn = FunctionBuilder::new(&[], &[]);
let global_map_init_id = global_map_init_fn.finish_module(app_wasm);

let mut global_map_init = app_wasm.functions.get_fn_modifier(global_map_init_id)
global_map_init.func_entry();
global_map_init.i32_const(0);
@ejrgilbert ejrgilbert added the bug Something isn't working label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant