Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem naming #56

Open
nofxx opened this issue Dec 7, 2014 · 1 comment
Open

Gem naming #56

nofxx opened this issue Dec 7, 2014 · 1 comment

Comments

@nofxx
Copy link

nofxx commented Dec 7, 2014

Hello @thetron , and thanks for this plugin, just recently found it out.

Ok, half my OCD, half maybe avoid future confusion and chaos:
I'm going in plugins to suggest correct gem naming:
http://guides.rubygems.org/name-your-gem/

To fix you could remove lib/mongoid_token.rb or add a deprecated message to it.
gem 'mongoid-token'
require 'mongoid/token'
include Mongoid::Token

All good then. Thank you!

I realize you need to create another rubygem, with hyphen and rename the project here.
Up to you, I'm going to do that in a bad named plugin I have, github now stores old urls and redirects, sounds fine.

@thetron
Copy link
Owner

thetron commented Jul 22, 2015

@nofxx My apologies for the delay responding here. I completely agree, and often thing about this too 😄. I don't think I'm going to be able to make the change super soon, but i'm going to leave this issue open so that I don't forget to follow up on it again.

Thanks for the feedback! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants