Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Addendance Search only search for one page #176

Open
sisminnmaw opened this issue Oct 14, 2021 · 8 comments
Open

[Frontend] Addendance Search only search for one page #176

sisminnmaw opened this issue Oct 14, 2021 · 8 comments
Labels
bug Something isn't working frontend hacktoberfest

Comments

@sisminnmaw
Copy link
Member

[bug]
Search in single page's records
[need to fix]
Search in entire records

@khinezarthwe
Copy link
Member

khinezarthwe commented Oct 14, 2021

@sisminnmaw is this API error or frontend bug ?

@sisminnmaw
Copy link
Member Author

@khinezarthwe frontend,
there is no API call for search, just searched on single page data.

@khinezarthwe khinezarthwe added frontend hacktoberfest bug Something isn't working labels Oct 14, 2021
@mtwn105
Copy link

mtwn105 commented Oct 14, 2021

Hi @khinezarthwe can I try this?

@mtwn105
Copy link

mtwn105 commented Oct 14, 2021

Hey @khinezarthwe I did the setup as per README.md ( started draft server -> edited package.json -> started fronted)
But it says 404 not found on login
image

@khinezarthwe
Copy link
Member

@dreamingblackcat @sisminnmaw Could you two please take a look at this?

@sisminnmaw
Copy link
Member Author

sisminnmaw commented Oct 15, 2021

@mtwn105

There is .env.example file in your frontend/src path.
copy or change name to .env.local and then
set to REACT_APP_USE_DRAFT_API=true.

could you try with this?

Screen Shot 2021-10-15 at 4 29 58 PM

@khinezarthwe currently draft server is not working well, all data are wrongs. we need to fix it.

@dreamingblackcat dreamingblackcat changed the title Addendance Search only search for one page [Frontend] Addendance Search only search for one page Oct 16, 2021
@dreamingblackcat
Copy link
Member

dreamingblackcat commented Oct 16, 2021

@mtwn105 Sorry, this might not be the best issue for the new comers to the project as this involve both updating Python api and the UI.

I've separated the backend side of this to #180 but this issue can only be picked after #180 is finished.

I'll unassigned this from you for now as this is blocked.

EDIT Also, @sisminnmaw , now that we have a working python api, we're no longer maintaining the draft server anymore. This is on me. I'll create an issue to remove the draft server and its set up instructions from Readme.

@mtwn105
Copy link

mtwn105 commented Oct 16, 2021

Okay @dreamingblackcat thanks for letting me know. It was nice to interact with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend hacktoberfest
Projects
None yet
Development

No branches or pull requests

4 participants