[feat]: Add an infinite image slider issue #954 #957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you just created two directories image-slider and imageSlider what I am asking is ImageSlider which is pascal cased, also delete the former two directories before I can merge your changes. |
|
Sorry for that problem, finally the task has now been completed on 4d89800 commit. It's ready to be merged. |
PBJI
added
the
changeRequested
what I am asking is ImageSlider which is pascal cased |
|
Sorry for the misunderstanding, now the camelCase has been updated to PascalCase on 5ab4cbd commit and it's ready to be merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Adding Infinite Image Slider Mini-Project
Description
This pull request addresses the feature request issue #954, where we propose the addition of a new mini-project, the Infinite Image Slider, to the
javascript-mini-projectsrepository. The project has been created using HTML, CSS, and JavaScript, providing an engaging and educational resource for learners and web developers.Attachments
Please review this pull request and consider merging it into the main project repository. If any further adjustments are needed or if you have any feedback, please let us know. Thank you for your consideration.
Closes #954