feat: add sparkplug b encoder for publishing #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferm10n
force-pushed
the
encoding-sparkplug
branch
from
3dc2019
to
d724dbc
Compare
|
Also I should mention that I fixed the linting step in CI. I hope that was ok. Doing so exposed a warning in an unrelated file, that I'm not sure how to address. |
|
@ferm10n Can you rebase this, and hopefully we can get it merged? |
ferm10n
force-pushed
the
encoding-sparkplug
branch
from
adae442
to
4df2577
Compare
needs error handling
…tall --production`
ferm10n
force-pushed
the
encoding-sparkplug
branch
from
e826405
to
58c3c9e
Compare
|
@bj00rn ready for review. I did have a question about https://github.com/thomasnordquist/MQTT-Explorer/pull/655/files#diff-5255694efe3f339a40eef198ab371f5c050b53e65146bb32aa2dbb2427646beaR39, did you have a preference on how to handle an error when trying to encode a sparkplug payload (for example when the user provides a payload that cannot be sparkplug encoded) |
|
@ferm10n thanks for this, I think we have to sort out decoding/encoding logic before looking into this there are a few issues/pr around this ATM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing off the work of #629 and #582, this PR adds the ability to publish sparkplug B payloads.
I'm looking for input on the method used for determining when to encode (checking if the topic is sparkplug like via regex) and how error handling should be done when the format is incorrect (currently a no-op)