Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: virtualize rendering #798

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

thomasnordquist
Copy link
Owner

@thomasnordquist thomasnordquist commented May 24, 2024

This reduces CPU consumption massivly and allows to display GIANT

  • check that ViewModel is released when no longer used
  • check memory consumption in general
  • fix auto expand (currently everything is expanded, logic needs to move to ViewModel since the react state is lost when component moves outside of viewport
  • fix activity highlighting (blinks more then expected)
  • topic ordering probably needs to be re-implemented in ViewModel

Downside

Scrolling is a bit weird with very long lists, the virtualization has some issues maintaining the scroll index if data is added / removed before the scroll position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants