Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_modules included #5

Open
kustomzone opened this issue Oct 1, 2024 · 1 comment
Open

node_modules included #5

kustomzone opened this issue Oct 1, 2024 · 1 comment

Comments

@kustomzone
Copy link

Hi, were src/js/frontend/node_modules and src/js/backend/node_modules included by accident?
They are .gitignored in Resources/ so pnpm install --recursive (or similar) could be added to the 'Test App' instructions?

@thomastschurtschenthaler
Copy link
Owner

Hi, src/js/frontend/node_modules and src/js/backend/node_modules are required by electrico itself.
I included them to make it easier for users to start first tests with electrico (no npm install or custom script, only rustup/cargo toolchain needed).
The test app /Resources/* has its only dependency on 'electron', which is not needed by electrico.
If you want to start the test app with electron - from folder /Resources run:
npm install
npm run start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants