Migrate Test Method With Generics

[viceroypenguin]

Current XUnit Code:

[Theory]
[MemberData(nameof(AggregateBy_TestData))]
public static void AggregateBy_HasExpectedOutput<TSource, TKey, TAccumulate>(
	IEnumerable<TSource> source,
	Func<TSource, TKey> keySelector,
	Func<TKey, TAccumulate> seedSelector,
	Func<TAccumulate, TSource, TAccumulate> func,
	IEqualityComparer<TKey>? comparer,
	IEnumerable<KeyValuePair<TKey, TAccumulate>> expected) where TKey : notnull
{
	using var ts = source.AsTestingSequence();
	SuperEnumerable
		.AggregateBy(ts, keySelector, seedSelector, func, comparer)
		.AssertCollectionEqual(expected);
}

public static IEnumerable<object?[]> AggregateBy_TestData()
{
	yield return WrapArgs(
		source: Enumerable.Range(0, 10),
		keySelector: x => x,
		seedSelector: x => 0,
		func: (x, y) => x + y,
		comparer: null,
		expected: Enumerable.Range(0, 10).ToDictionary(x => x, x => x));

	yield return WrapArgs(
		source: ["Bob", "bob", "tim", "Bob", "Tim"],
		keySelector: x => x,
		seedSelector: x => "",
		func: (x, y) => x + y,
		comparer: null,
		expected: new Dictionary<string, string>(StringComparer.Ordinal)
		{
			{ "Bob", "BobBob" },
			{ "bob", "bob" },
			{ "tim", "tim" },
			{ "Tim", "Tim" },
		});

	// .. other test cases

	static object?[] WrapArgs<TSource, TKey, TAccumulate>(IEnumerable<TSource> source, Func<TSource, TKey> keySelector, Func<TKey, TAccumulate> seedSelector, Func<TAccumulate, TSource, TAccumulate> func, IEqualityComparer<TKey>? comparer, IEnumerable<KeyValuePair<TKey, TAccumulate>> expected)
		=> [source, keySelector, seedSelector, func, comparer, expected];
}

What would be the best way to migrate this to TUnit [MethodDataSource]?

[thomhurst]

That is some complicated test haha, just trying to wrap my head around what it's doing!

I see you've raised an issue, is that to sort this?

I think extending method data source to allow inputs seems like a good idea so I'm happy to try and incorporate that

[thomhurst]

Also, if you suppress the analyzer, does it work/run?

Curious if I need to fix two things or just the analyzer

[viceroypenguin]

I'm in the middle of a major refactor, so I can't retry on my code atm. When I'm closer to a place where it runs, I'll give it a try.

[thomhurst]

No worries. If I get some time tomorrow I'll try and reproduce it myself

[thomhurst]

@viceroypenguin I had to make some changes to TUnit to support generic tests like this, but it works!
Example here: https://github.com/thomhurst/TUnit/blob/main/TUnit.TestProject/GenericMethodTests.cs

public class GenericMethodTests
{
    [Test]
    [MethodDataSource(nameof(AggregateBy_Numeric_TestData))]
    [MethodDataSource(nameof(AggregateBy_String_TestData))]
    public void AggregateBy_HasExpectedOutput<TSource, TKey, TAccumulate>(
        IEnumerable<TSource> source,
        Func<TSource, TKey> keySelector,
        Func<TKey, TAccumulate> seedSelector,
        Func<TAccumulate, TSource, TAccumulate> func,
        IEqualityComparer<TKey>? comparer,
        IEnumerable<KeyValuePair<TKey, TAccumulate>> expected) where TKey : notnull
    {
        var enumerable = source as TSource[] ?? source.ToArray();
        Console.WriteLine(string.Join(", ", enumerable));
        Console.WriteLine(string.Join(", ", enumerable.Select(keySelector)));
        Console.WriteLine(string.Join(", ", enumerable.Select(x => seedSelector(keySelector(x)))));
    }

    public static IEnumerable<(IEnumerable<int> source,
        Func<int, int> keySelector,
        Func<int, int> seedSelector,
        Func<int, int, int> func,
        IEqualityComparer<int>? comparer,
        IEnumerable<KeyValuePair<int, int>> expected)> AggregateBy_Numeric_TestData()
    {
        yield return (
            source: Enumerable.Range(0, 10),
            keySelector: x => x,
            seedSelector: x => 0,
            func: (x, y) => x + y,
            comparer: null,
            expected: Enumerable.Range(0, 10).ToDictionary(x => x, x => x)
        );
    }
    
    public static IEnumerable<(IEnumerable<string> source,
        Func<string, string> keySelector,
        Func<string, string> seedSelector,
        Func<string, string, string> func,
        IEqualityComparer<string>? comparer,
        IEnumerable<KeyValuePair<string, string>> expected)> AggregateBy_String_TestData()
    {
        yield return (
            source: ["Bob", "bob", "tim", "Bob", "Tim"],
            keySelector: x => x,
            seedSelector: x => "",
            func: (x, y) => x + y,
            comparer: null,
            expected: new Dictionary<string, string>(StringComparer.Ordinal)
            {
                { "Bob", "BobBob" },
                { "bob", "bob" },
                { "tim", "tim" },
                { "Tim", "Tim" },
            });
    }
}

[viceroypenguin]

Wow! You're incredible! I'll take advantage of that when I get back to SuperLinq tomorrow or Monday! Thank you!