Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advise tests are failing on ocp4-stage because advise documents are still being processed #324

Open
mayaCostantini opened this issue Jun 8, 2022 · 7 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.

Comments

@mayaCostantini
Copy link
Contributor

Describe the bug

See last integration-tests results for ocp4-stage (2022-06-08 version 0.11.2):

thamos.swagger_client.rest.ApiException: (400)
Reason: BAD REQUEST
HTTP response headers: HTTPHeaderDict({'server': 'gunicorn', 'date': 'Wed, 08 Jun 2022 02:59:35 GMT', 'content-type': 'application/json', 'content-length': '272', 'x-thoth-version': '0.35.2', 'x-user-api-service-version': '0.35.2+messaging.0.16.1.storages.0.72.1.common.0.36.2.python.0.16.10', 'x-thoth-search-ui-url': 'https://thoth-station.ninja/search/', 'access-control-allow-origin': '*', 'set-cookie': '694c408f5a01f44faf6d9d4ad450ae31=4120f5cc8c811522e7dc4bcb98484603; path=/; HttpOnly; Secure; SameSite=None'})
HTTP response body: b'{\n  "error": "Analysis was not successful",\n  "parameters": {\n    "analysis_id": "adviser-220608025846-adbb4959f5e011e8"\n  },\n  "status": {\n    "finished_at": "2022-06-08T02:59:31Z",\n    "reason": null,\n    "started_at": "2022-06-08T02:58:46Z",\n    "state": "error"\n  }\n}\n'


Captured logging:
INFO:thamos.lib:Using 'latest' recommendation type - see https://thoth-station.ninja/recommendation-types/
WARNING:thamos.lib:The user stack found in the lock file will not be supplied as requested
INFO:thamos.lib:Successfully submitted advise analysis 'adviser-220608025846-adbb4959f5e011e8' to 'https://stage.thoth-station.ninja/api/v1'

Querying the advise document with id adviser-220608025846-adbb4959f5e011e8 on the user API shows that it is still being queued for processing.

Expected behavior

Advise documents are processed on time.

@mayaCostantini
Copy link
Contributor Author

/priority critical-urgent
/sig stack-guidance
/kind bug

@sesheta sesheta added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. kind/bug Categorizes issue or PR as related to a bug. labels Jun 8, 2022
@mayaCostantini
Copy link
Contributor Author

Same situation for provenance-check reports:

{
  "error": "Analysis 'provenance-checker-220608030117-61599c0f33a7ba02' is being queued and scheduled for processing",
  "parameters": {
    "analysis_id": "provenance-checker-220608030117-61599c0f33a7ba02"
  },
  "status": {
    "finished_at": null,
    "reason": null,
    "started_at": null,
    "state": "pending"
  }
}

@fridex
Copy link
Contributor

fridex commented Jun 8, 2022

Same situation for provenance-check reports:

This response is expected (check also HTTP status code). It looks like there was a request to obtain the given provenance-checker document, but it hasn't been created yet. provenance-checker was scheduled and queued to produce the given document.

@mayaCostantini
Copy link
Contributor Author

mayaCostantini commented Jun 8, 2022

This response is expected

Agree 👍 I opened this issue to track if we lacked resources or if there was any issue creating the documents in time for integration tests to pass

@mayaCostantini
Copy link
Contributor Author

mayaCostantini commented Jun 8, 2022

This response is expected

Agree +1 I opened this issue to track if we lacked resources or if there was any issue creating the documents in time for integration tests to pass

Ah sorry I got confused with status codes. Right, thanks for pointing it out!

@sesheta
Copy link
Member

sesheta commented Sep 6, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 6, 2022
@harshad16
Copy link
Member

/remove-lifecycle stale
/lifecycle frozen

@sesheta sesheta added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.
Projects
None yet
Development

No branches or pull requests

4 participants