Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create overlay by default for each notebook #115

Open
pacospace opened this issue Feb 12, 2021 · 12 comments
Open

Do not create overlay by default for each notebook #115

pacospace opened this issue Feb 12, 2021 · 12 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Issues targeting the hacktoberfest participants. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature.

Comments

@pacospace
Copy link
Contributor

Is your feature request related to a problem? Please describe.

As Data Scientist,

I don't want to have an overlay for all my notebooks. I want to have the possibility to choose which notebook needs an overlay.

Describe the solution you'd like
Have a configuration parameter for users set by default to no. This is important togheter with the possibility to build from overlays, so that overlays image for notebooks that are not used in any pipelines are created. (discussing with @harshad16 )

Describe alternatives you've considered

Additional context
@pacospace pacospace added sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 12, 2021
@sesheta
Copy link
Member

sesheta commented May 13, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2021
@pacospace
Copy link
Contributor Author

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 14, 2021
@goern
Copy link
Member

goern commented Jun 10, 2021

/priority backlog

@sesheta sesheta added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jun 10, 2021
@pacospace pacospace added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Issues targeting the hacktoberfest participants. labels Jul 6, 2021
@sesheta
Copy link
Member

sesheta commented Aug 5, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 5, 2021
@pacospace
Copy link
Contributor Author

/remove-lifecycle rotten

@sesheta sesheta removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 6, 2021
@pacospace pacospace added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Aug 6, 2021
@sesheta
Copy link
Member

sesheta commented Sep 5, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link
Member

sesheta commented Sep 5, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Sep 5, 2021
@pacospace
Copy link
Contributor Author

Is your feature request related to a problem? Please describe.

As Data Scientist,

I don't want to have an overlay for all my notebooks. I want to have the possibility to choose which notebook needs an overlay.

Describe the solution you'd like
Have a configuration parameter for users set by default to no. This is important togheter with the possibility to build from overlays, so that overlays image for notebooks that are not used in any pipelines are created. (discussing with @harshad16 )

Describe alternatives you've considered

Additional context

This behaviour is present only in the UI version of jupyterlab-requirements, CLI and magic commands require a speicific flag --use-overlays to save overlays.

@pacospace pacospace reopened this Sep 6, 2021
@sesheta
Copy link
Member

sesheta commented Oct 6, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this as completed Oct 6, 2021
@sesheta
Copy link
Member

sesheta commented Oct 6, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacospace pacospace reopened this Oct 6, 2021
@goern
Copy link
Member

goern commented Nov 23, 2021

/area byon

@sesheta sesheta added the wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature. label Nov 23, 2021
@Gkrumbach07 Gkrumbach07 removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jul 19, 2022
@Gkrumbach07
Copy link
Member

story points 3

@codificat codificat moved this to 🆕 New in Planning Board Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Issues targeting the hacktoberfest participants. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature.
Projects
Planning Board
Status: 🆕 New
jupyterlab-requirements
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@goern @Gkrumbach07 @pacospace @sesheta