Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure API constraints are respected #291

Open
1 task
pacospace opened this issue Jun 9, 2021 · 7 comments
Open
1 task

Make sure API constraints are respected #291

pacospace opened this issue Jun 9, 2021 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pacospace
Copy link
Contributor

pacospace commented Jun 9, 2021

Is your feature request related to a problem? Please describe.
As Maintainer,

I would like to have checks between https://github.com/thoth-station/jupyterlab-requirements/blob/master/jupyterlab_requirements/dependency_management/jupyterlab_requirements.yaml and actual API handlers implemented in order to improve testing and make sure failures would not happen across releases.

Describe the solution you'd like

  • Introduce logic to verify API constraints from .yaml are matched on the API handlers.

Describe alternatives you've considered

Additional context
Add any other context or screenshots about the feature request here.

@goern
Copy link
Member

goern commented Jun 10, 2021

/kind feature
/triage needs-information

@sesheta sesheta added kind/feature Categorizes issue or PR as related to a new feature. triage/needs-information Indicates an issue needs more information in order to work on it. labels Jun 10, 2021
@sesheta
Copy link
Member

sesheta commented Jul 15, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this as completed Jul 15, 2021
@sesheta
Copy link
Member

sesheta commented Jul 15, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacospace pacospace reopened this Jul 16, 2021
@sesheta
Copy link
Member

sesheta commented Aug 24, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 24, 2021
@pacospace pacospace added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Sep 9, 2021
@pacospace pacospace added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed triage/needs-information Indicates an issue needs more information in order to work on it. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Oct 6, 2021
@goern
Copy link
Member

goern commented Nov 23, 2021

/area byon

@sesheta sesheta added the wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature. label Nov 23, 2021
@codificat
Copy link
Member

This seems to be about adding testing to verify that the extension keeps up to date with API changes

/sig user-experience

@sesheta sesheta added the sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. label Aug 29, 2022
@VannTen
Copy link
Member

VannTen commented Aug 29, 2022

This seems to be about adding testing to verify that the extension keeps up to date with API changes

Another option would be to generate one from the other to make mismatch impossible, if that's possible. (might not be)

@codificat codificat moved this to 📋 Backlog in Planning Board Sep 24, 2022
@codificat codificat removed the wg/cre Issues or PRs related to the Custom Runtime Environment (fka Custom Notebook Image) ODH feature. label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 📋 Backlog
Status: Backlog
Development

No branches or pull requests

5 participants