-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Git LFS in s2i #179
Comments
CC @frenzymadness is this something reasonable to support in Python s2i? |
/kind feature |
I have to admit that I have zero experience with git lfs. Do you have an example of a repository using it? But if I understand it correctly, this is not about the images. You can use an image manually (Dockerfile) or with s2i tool. In the first case, you have to also manually prepare the source code in advance. When using the s2i tool, the tool generates the Dockerfile and prepares the sources for you which make me think that the support for git LFS should be implemented there: https://github.com/openshift/source-to-image And I see somebody already opened an issue for it: openshift/source-to-image#1032 It seems that they found a workaround so reopening the issue or using their workaround might be a good next step. |
/triage needs-information |
/priority backlog |
Rotten issues close after 30d of inactivity. /close |
@sesheta: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Rotten issues close after 30d of inactivity. /close |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
@sesheta: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is your feature request related to a problem? Please describe.
Currently, when creating an image from a repo that uses git LFS, the files stored are not treated as git LFS and therefore cannot be read, if that image is spawned on JH on ODH for example.
Another issue is when we want to deploy an ML model that is stored as git LFS.
Describe the solution you'd like
Create logic that handle git LFS in s2i when creating a content image or an image for model deployment.
Describe alternatives you've considered
See: https://github.com/orgs/thoth-station/projects/15#card-50864817
Additional context
See: thoth-station/datasets#31
See: https://github.com/orgs/thoth-station/projects/15#card-50864817
The text was updated successfully, but these errors were encountered: