Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Git LFS in s2i #179

Closed
pacospace opened this issue May 6, 2021 · 10 comments
Closed

Handle Git LFS in s2i #179

pacospace opened this issue May 6, 2021 · 10 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@pacospace
Copy link
Contributor

pacospace commented May 6, 2021

Is your feature request related to a problem? Please describe.
Currently, when creating an image from a repo that uses git LFS, the files stored are not treated as git LFS and therefore cannot be read, if that image is spawned on JH on ODH for example.

Another issue is when we want to deploy an ML model that is stored as git LFS.

Describe the solution you'd like
Create logic that handle git LFS in s2i when creating a content image or an image for model deployment.

Describe alternatives you've considered
See: https://github.com/orgs/thoth-station/projects/15#card-50864817

Additional context
See: thoth-station/datasets#31
See: https://github.com/orgs/thoth-station/projects/15#card-50864817

@fridex
Copy link
Contributor

fridex commented May 10, 2021

CC @frenzymadness is this something reasonable to support in Python s2i?

@goern
Copy link
Member

goern commented May 10, 2021

/kind feature

@sesheta sesheta added the kind/feature Categorizes issue or PR as related to a new feature. label May 10, 2021
@frenzymadness
Copy link

I have to admit that I have zero experience with git lfs. Do you have an example of a repository using it?

But if I understand it correctly, this is not about the images. You can use an image manually (Dockerfile) or with s2i tool. In the first case, you have to also manually prepare the source code in advance. When using the s2i tool, the tool generates the Dockerfile and prepares the sources for you which make me think that the support for git LFS should be implemented there: https://github.com/openshift/source-to-image

And I see somebody already opened an issue for it: openshift/source-to-image#1032 It seems that they found a workaround so reopening the issue or using their workaround might be a good next step.

@goern
Copy link
Member

goern commented Jun 10, 2021

/triage needs-information

@sesheta sesheta added the triage/needs-information Indicates an issue needs more information in order to work on it. label Jun 10, 2021
@goern
Copy link
Member

goern commented Jun 15, 2021

/priority backlog

@sesheta sesheta added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jun 15, 2021
@goern goern removed the triage/needs-information Indicates an issue needs more information in order to work on it. label Jul 13, 2021
@sesheta
Copy link
Member

sesheta commented Aug 23, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this as completed Aug 23, 2021
@sesheta
Copy link
Member

sesheta commented Aug 23, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacospace pacospace reopened this Aug 24, 2021
@sesheta
Copy link
Member

sesheta commented Sep 23, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link
Member

sesheta commented Sep 23, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 23, 2021
@sesheta sesheta closed this as completed Sep 23, 2021
@sesheta
Copy link
Member

sesheta commented Sep 23, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants