Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to browse advise results #66

Closed
fridex opened this issue Mar 29, 2022 · 4 comments
Closed

Unable to browse advise results #66

fridex opened this issue Mar 29, 2022 · 4 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fridex
Copy link
Contributor

fridex commented Mar 29, 2022

Describe the bug

I'm unable to browse adviser results.

To Reproduce
Steps to reproduce the behavior:

  1. Trigger thamos advise
  2. Wait for the recommendations to be computed
  3. Check the URL to Thoth Search reported - ex. https://thoth-station.ninja/search/adviser-220329062130-e66ea4b2a189ee44/summary
  4. See an error

Expected behavior

Thoth Search UI should show results of the advise.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@fridex fridex added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels Mar 29, 2022
@Gkrumbach07
Copy link
Member

This is because that advise document does not include a lockfile as an input parameter. Usually the old pipfile is used to compare with the new pipfile. I believe the solution to this is to add a feature to select one or two environments to compare (or just one environment). This will allow for advises that dont have an input lockfile, and open up ways to compare environments across different operating systems or python versions.

I will prioritize this feature for the next sprint: #64

@fridex
Copy link
Contributor Author

fridex commented Mar 29, 2022

This is because that advise document does not include a lockfile as an input parameter

The lock file is optional in inputt. The supplied lock file is used as a base for scoring dependencies that the user already uses. If the user does not have any lockfile yet (or she/he opts out from submitting it explicitly) we generate one for the user - https://thoth-station.ninja/j/user_stack

@Gkrumbach07
Copy link
Member

/triage accepted
/lifecycle active
/priority important-soon

@sesheta sesheta added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 1, 2022
@Gkrumbach07 Gkrumbach07 self-assigned this Apr 1, 2022
@Gkrumbach07 Gkrumbach07 mentioned this issue Apr 8, 2022
1 task
@Gkrumbach07 Gkrumbach07 removed the needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. label Apr 8, 2022
@Gkrumbach07
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants