✨ Support eval_gemfile #248

pboling · 2025-02-03T15:13:24Z

Fixes Appraisal doesn't support eval_gemfile #154

pboling · 2025-02-03T15:23:49Z

I think the test suite was already broken before I made any changes @nickcharlton

The new test I wrote for eval_gemfile should be passing though.

pboling · 2025-02-03T15:24:23Z

spec/acceptance/eval_gemfile_spec.rb

+  end
+
+  def build_gemspec(path = ".")
+    Dir.mkdir("tmp/stage/#{path}") rescue nil


This was an existing pattern in the tests I merely copied.

pboling · 2025-02-03T15:24:28Z

spec/acceptance/eval_gemfile_spec.rb

+  end
+
+  def build_modular_gemfile
+    Dir.mkdir("tmp/stage/gemfiles") rescue nil


This was an existing pattern in the tests I merely copied.

- thoughtbot/appraisal#248

pboling · 2025-02-12T17:21:14Z

ping @nickcharlton 🔶

n-rodriguez · 2025-02-19T20:02:28Z

@pboling

I think the test suite was already broken before I made any changes

I don't think so, see: https://github.com/thoughtbot/appraisal/actions/runs/10999060013, but it might be due to a change in Bundler 😢

pboling · 2025-02-20T06:05:14Z

Interesting. Actually there may only be a few minor failures. From the Ruby 3.4 build:

            expected: 
"# This file was generated by Appraisal\n\nsource \"[https://rubygems.org\](https://rubygems.org/)"\n\nruby({:file=>\".ruby-version\"})\n\ngem \"appraisal\", :path => \"/home/runner/work/appraisal/appraisal\"\n"
            got:
"# This file was generated by Appraisal\n\nsource \"[https://rubygems.org\](https://rubygems.org/)"\n\n:ruby({file => \".ruby-version\"})\n\ngem \"appraisal\", :path => \"/home/runner/work/appraisal/appraisal\"\n"

The difference is there are spaces around the => for :file in got, but not expected. Oddly the spaces around => for :path are the same in both...

Also there is a semicolon before ruby for expected, but not for got. This seems like tests may not have been modified properly according to the way hashes print in Ruby 3.4?

pboling · 2025-02-20T18:51:06Z

@nickcharlton I tihnk some of the failures were legit broken stuff. I've fixed pretty much everything (and done some other things too) in a new PR:
#249

This reverts commit 92d5134.

- https://dev.to/galtzo/matrix-ruby-gem-bundler-etc-4kk7

n-rodriguez · 2025-02-20T22:16:39Z

@pboling thank you!
@nickcharlton LGTM

- Support debug for debugging with Ruby >= 2.7 - Support byebug for debugging with Ruby < 2.7

- thoughtbot#250 (comment)

…d matrix - all current jruby and truffleruby are compatible with Ruby 3.1 at minimum, thus are supported by latest bundler

- Use strip_heredoc uniformly in acceptance tests

- thoughtbot#250 (comment)

- Differences in handling of whitespace between versions of Ruby are often seen as minor, and go unnoticed unless tests explicitly test white space as appraisal's test suite does.

Gemfile

lib/appraisal/appraisal.rb

pboling · 2025-02-21T22:45:44Z

Rebased on top of the PR that fixes the build (#250) down to Ruby 2.7.

- thoughtbot/appraisal#250 - thoughtbot/appraisal#248

- Ruby < 2 compat

- Possibly due to bundler issue on MRI and JRuby engines - rubygems/rubygems#8518

- Fixes thoughtbot#154

pboling · 2025-02-24T20:02:45Z

Rebased on my lts branch again, which should make the build green here.

hound · 2025-02-24T20:02:45Z

lib/appraisal/task.rb

-      desc "Run the given task for all appraisals"
-      task appraisal: "appraisal:all"
+      desc("Run the given task for all appraisals")
+      task(:appraisal => "appraisal:all")


Style/HashSyntax: Use the new Ruby 1.9 hash syntax.

hound · 2025-02-24T20:02:45Z

lib/appraisal/task.rb

          ARGV.shift
-          exec "bundle exec appraisal rake #{ARGV.join(' ')}"
+          exec("bundle exec appraisal rake #{ARGV.join(" ")}")


Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.

hound · 2025-02-24T20:02:45Z

lib/appraisal/task.rb

-              exec "bundle exec appraisal #{appraisal.name} rake #{ARGV.join(' ')}"
+              warn("`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " \
+                "Please use `appraisal #{appraisal.name} rake #{ARGV.join(" ")}`.")
+              exec("bundle exec appraisal #{appraisal.name} rake #{ARGV.join(" ")}")


Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
Metrics/LineLength: Line is too long. [84/80]

hound · 2025-02-24T20:02:45Z

lib/appraisal/task.rb

-                "Please use `appraisal #{appraisal.name} rake #{ARGV.join(' ')}`."
-              exec "bundle exec appraisal #{appraisal.name} rake #{ARGV.join(' ')}"
+              warn("`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " \
+                "Please use `appraisal #{appraisal.name} rake #{ARGV.join(" ")}`.")


Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
Metrics/LineLength: Line is too long. [83/80]

hound · 2025-02-24T20:02:45Z

lib/appraisal/task.rb

-              warn "`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " +
-                "Please use `appraisal #{appraisal.name} rake #{ARGV.join(' ')}`."
-              exec "bundle exec appraisal #{appraisal.name} rake #{ARGV.join(' ')}"
+              warn("`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " \


Metrics/LineLength: Line is too long. [103/80]

hound · 2025-02-24T20:02:46Z

lib/appraisal/utils.rb

@@ -24,30 +31,31 @@ def self.format_string(object, enclosing_object = false)
      end
    end

+    # Appraisal needs to print Gemfiles in the oldest Ruby syntax that is supported by Appraisal.
+    # This means formatting Hashes as Rockets, until support for Ruby 1.8 is dropped.


Metrics/LineLength: Line is too long. [85/80]

hound · 2025-02-24T20:02:46Z

lib/appraisal/utils.rb

@@ -24,30 +31,31 @@ def self.format_string(object, enclosing_object = false)
      end
    end

+    # Appraisal needs to print Gemfiles in the oldest Ruby syntax that is supported by Appraisal.


Metrics/LineLength: Line is too long. [97/80]

hound · 2025-02-24T20:02:46Z

lib/appraisal/utils.rb

@@ -15,7 +22,7 @@ def self.format_string(object, enclosing_object = false)
        end

        if enclosing_object
-          "{ #{items.join(', ')} }"
+          "{ #{items.join(", ")} }"


Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.

hound · 2025-02-24T20:02:46Z

lib/appraisal/utils.rb

+    end
+
+    # Appraisal needs to print Gemfiles in the oldest Ruby syntax that is supported by Appraisal.
+    # Otherwise, a project would not be able to use Appraisal to test compatibility


Metrics/LineLength: Line is too long. [83/80]

hound · 2025-02-24T20:02:46Z

lib/appraisal/utils.rb

+      Gem::Version.create(Bundler::VERSION) > Gem::Version.create("2.4.22")
+    end
+
+    # Appraisal needs to print Gemfiles in the oldest Ruby syntax that is supported by Appraisal.


Metrics/LineLength: Line is too long. [97/80]

pboling commented Feb 3, 2025

View reviewed changes

pboling mentioned this pull request Feb 3, 2025

Appraisal doesn't support eval_gemfile #154

Open

pboling force-pushed the eval_gemfile branch 3 times, most recently from 9f19d18 to 05d6d9c Compare February 3, 2025 15:44

pboling added a commit to VitalConnectInc/turbo_tests that referenced this pull request Feb 3, 2025

✨ Utilize eval_gemfile with appraisals

35d43e3

- thoughtbot/appraisal#248

pboling mentioned this pull request Feb 18, 2025

Appraisal v3 #204

Open

pboling mentioned this pull request Feb 20, 2025

eval_gemfile + LTS support #249

Closed

pboling added 2 commits February 21, 2025 04:20

Revert "Drop MRI 1.8.7-2.2 support (thoughtbot#158)"

9860cb9

This reverts commit 92d5134.

💚 Fix bundler versions per Ruby version

14f36cd

- https://dev.to/galtzo/matrix-ruby-gem-bundler-etc-4kk7

n-rodriguez approved these changes Feb 20, 2025

View reviewed changes

pboling added 12 commits February 21, 2025 05:34

💚 Fix ruby declaration in Gemfile when on ruby-head

79a6de1

- Support debug for debugging with Ruby >= 2.7 - Support byebug for debugging with Ruby < 2.7

🚨 Address code review from @n-rodriguez

2d022fc

- thoughtbot#250 (comment)

👷 Add Rubies 2.7, 2.6, 2.5, 2.4, 2.3, 2.2, 2.1, 2.0, 1.9, 1.8 to buil…

df41df2

…d matrix - all current jruby and truffleruby are compatible with Ruby 3.1 at minimum, thus are supported by latest bundler

♻️ Use .rspec to dry spec file headers

1a5b85d

- Use strip_heredoc uniformly in acceptance tests

🚨 Address code review from @n-rodriguez

a19e707

- thoughtbot#250 (comment)

🐛 Fixes for Ruby 2.7 compat

e1673bc

- Differences in handling of whitespace between versions of Ruby are often seen as minor, and go unnoticed unless tests explicitly test white space as appraisal's test suite does.

👷 add Ruby 3.4

4ec2725

🐛 Fix inconsistent indentation

594690d

📝 Documentation

386ddb6

💚 Fix inconsistent indentation in spec fixtures

7a2ec8e

🚨 Lint lock update

f722561

👷 Add Ruby 2.6

12002da

pboling added 3 commits February 22, 2025 05:12

✏️ Lookahead != Lookbehind

df71fbb

✏️ Fix typo in documentation

5fcfb43

👷 Remove Ruby 2.6 from CI (to be added back in another PR)

975ded0

pboling force-pushed the eval_gemfile branch from 05d6d9c to 774054c Compare February 21, 2025 22:44

hound bot reviewed Feb 21, 2025

View reviewed changes

📝 Documentation

46d71e6

pboling added a commit to pboling/gem_checksums that referenced this pull request Feb 22, 2025

➕ gem "appraisal", github: "pboling/appraisal", branch: "galtzo"

3fbfa17

- thoughtbot/appraisal#250 - thoughtbot/appraisal#248

pboling mentioned this pull request Feb 22, 2025

➕ gem "appraisal", github: "pboling/appraisal", branch: "galtzo" pboling/gem_checksums#1

Merged

pboling added 12 commits February 25, 2025 00:13

🐛 Ruby 1.8 compat: Replace __dir__ with File.dirname(__FILE__)

c07c0c9

🚨 Lint lock update

1ceb8ab

🐛 Ruby < 3.0 compat: Bifurcate the Modern Double Splat

8bffc9d

🐛 Ruby < 3.0 compat: Bifurcate the Modern Double Splat (redux)

f3595ab

🐛 Ruby < 3.0 compat: Bifurcate the Modern Double Splat (redux deux)

f582740

🐛 Ruby < 3.0 compat: Bifurcate the Modern Double Splat (tiga)

1579ad0

🐛 Ruby < 3.0 compat: Bifurcate the Modern Double Splat (empat)

a524ead

🚨 Style/SymbolArray: EnforcedStyle: brackets

df2a1e9

- Ruby < 2 compat

💚 Pend spec failure

0a02c86

- Possibly due to bundler issue on MRI and JRuby engines - rubygems/rubygems#8518

💚 skip tests that are known to fail on old bundler versions

be18441

💚 turn off truffleruby-head for now

198a324

✨ Support eval_gemfile

c353e3e

- Fixes thoughtbot#154

pboling force-pushed the eval_gemfile branch from 774054c to c353e3e Compare February 24, 2025 20:02

hound bot reviewed Feb 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Support eval_gemfile #248

✨ Support eval_gemfile #248

pboling commented Feb 3, 2025

pboling commented Feb 3, 2025 •

edited

Loading

pboling Feb 3, 2025

pboling Feb 3, 2025

pboling commented Feb 12, 2025

n-rodriguez commented Feb 19, 2025

pboling commented Feb 20, 2025 •

edited

Loading

pboling commented Feb 20, 2025

n-rodriguez commented Feb 20, 2025

pboling commented Feb 21, 2025 •

edited

Loading

pboling commented Feb 24, 2025

hound bot Feb 24, 2025

hound bot Feb 24, 2025

hound bot Feb 24, 2025

hound bot Feb 24, 2025

hound bot Feb 24, 2025

hound bot Feb 24, 2025

hound bot Feb 24, 2025

hound bot Feb 24, 2025

hound bot Feb 24, 2025

hound bot Feb 24, 2025

✨ Support eval_gemfile #248

Are you sure you want to change the base?

✨ Support eval_gemfile #248

Conversation

pboling commented Feb 3, 2025

pboling commented Feb 3, 2025 • edited Loading

pboling Feb 3, 2025

Choose a reason for hiding this comment

pboling Feb 3, 2025

Choose a reason for hiding this comment

pboling commented Feb 12, 2025

n-rodriguez commented Feb 19, 2025

pboling commented Feb 20, 2025 • edited Loading

pboling commented Feb 20, 2025

n-rodriguez commented Feb 20, 2025

pboling commented Feb 21, 2025 • edited Loading

pboling commented Feb 24, 2025

hound bot Feb 24, 2025

Choose a reason for hiding this comment

hound bot Feb 24, 2025

Choose a reason for hiding this comment

hound bot Feb 24, 2025

Choose a reason for hiding this comment

hound bot Feb 24, 2025

Choose a reason for hiding this comment

hound bot Feb 24, 2025

Choose a reason for hiding this comment

hound bot Feb 24, 2025

Choose a reason for hiding this comment

hound bot Feb 24, 2025

Choose a reason for hiding this comment

hound bot Feb 24, 2025

Choose a reason for hiding this comment

hound bot Feb 24, 2025

Choose a reason for hiding this comment

hound bot Feb 24, 2025

Choose a reason for hiding this comment

pboling commented Feb 3, 2025 •

edited

Loading

pboling commented Feb 20, 2025 •

edited

Loading

pboling commented Feb 21, 2025 •

edited

Loading