Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default<> is too easy to use incorrectly #18

Open
marcus-cellavision opened this issue Oct 17, 2023 · 0 comments
Open

Default<> is too easy to use incorrectly #18

marcus-cellavision opened this issue Oct 17, 2023 · 0 comments

Comments

@marcus-cellavision
Copy link

I think the Default<> template is hard to use and easily leads to mistakes, or at least multiple possibly unintended default executor instances (and thus more threads than intended).

In particular the static instances are not necessarily unique, globally, e.g. when used in different DLLs on Windows. I don't think this is the intention (?), however, the APIs make it all too easy not to provide an executor (and defaulting to Default<Executor>).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant