Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: flac support #23

Open
remenor opened this issue Oct 4, 2022 · 4 comments
Open

Feature request: flac support #23

remenor opened this issue Oct 4, 2022 · 4 comments

Comments

@remenor
Copy link

remenor commented Oct 4, 2022

The software is great.
Is it possible to add FLAC file reading and writing support?
Sorry for my english

@thp
Copy link
Owner

thp commented Oct 6, 2022

Yes, it's possible, but not implemented yet. As FLAC is lossless, you can decode the FLAC file, cut the WAV file and then re-encode to FLAC without any loss for now.

It might be convenient to skip the decoding/encoding step for cutting, but it's not as high priority as cutting lossy audio (as there decoding, cutting the WAV and re-encoding introduces generational loss).

@remenor
Copy link
Author

remenor commented Oct 6, 2022

I understand. Since it's not a priority (yet) is it possible to add support for the specification WAVEFORMATEXTENSIBLE?
I use it to cut demultiplexed audio with ffmpeg. If the wav format is used and the sample size is greater than 16 bits, wavbreaker cannot interpret it correctly. Apparently it can only open files with the legacy specification (PCMWAVEFORMAT)

@thp
Copy link
Owner

thp commented Oct 15, 2022

I understand. Since it's not a priority (yet) is it possible to add support for the specification WAVEFORMATEXTENSIBLE?
I use it to cut demultiplexed audio with ffmpeg. If the wav format is used and the sample size is greater than 16 bits, wavbreaker cannot interpret it correctly. Apparently it can only open files with the legacy specification (PCMWAVEFORMAT)

Please file a separate issue for this one, it's separate from FLAC support.

@remenor
Copy link
Author

remenor commented Oct 16, 2022

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants