Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dedup rebuild): if possible, use same backend during rebuild #142

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix(dedup rebuild): if possible, use same backend during rebuild #142

merged 2 commits into from
Dec 17, 2024

Conversation

iwanbk
Copy link
Member

@iwanbk iwanbk commented Dec 11, 2024 •
edited
Loading

Changes:

  • use previous backends if still alive
  • Only set the data on the new backends.

Fixes #5

@iwanbk iwanbk requested a review from LeeSmet as a code owner December 11, 2024 11:01
@iwanbk iwanbk mentioned this pull request Dec 11, 2024
Open
LeeSmet
LeeSmet requested changes Dec 13, 2024
View reviewed changes
zstor/src/actors/zstor.rs Outdated
debug!("Shard {} is the SAME", i);
} else {
used_backends.push((key, None));
warn!("Shard {} is DIFFERENT", i);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be a warning, not sure if these logs here are needed at all

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if these logs here are needed at all

You're correct for the other two logs:

debug!("Shard {} is the SAME", i);
debug!("Shard {} is MISSING", i);

I can remove it.

But i think the different case is needed and should be a warn, because it is unexpected to happens

@LeeSmet LeeSmet merged commit cb9771a into master Dec 17, 2024
4 checks passed
@LeeSmet LeeSmet deleted the dedup-rebuild branch December 17, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeSmet LeeSmet LeeSmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve rebuild logic
2 participants
@iwanbk @LeeSmet