Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU deployment node selection enhancement #3944

Open
1 task done
khaledyoussef24 opened this issue Feb 25, 2025 · 2 comments
Open
1 task done

GPU deployment node selection enhancement #3944

khaledyoussef24 opened this issue Feb 25, 2025 · 2 comments
Assignees
Labels
enhancements Small changes that can enhance the code/UI
Milestone

Comments

@khaledyoussef24
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

Tried to deploy a GPU machine on unrented node and got this errorImage
before it no warnings were shown

Image

can we make the deploy button in active unless user has a rented node ?

so can we make an error like this for node selection

Image

Steps To Reproduce

No response

which network/s did you face the problem on?

Main

version

next.dashboard

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

.

Relevant log output

.
@khaledyoussef24 khaledyoussef24 added the enhancements Small changes that can enhance the code/UI label Feb 25, 2025
@ramezsaeed ramezsaeed moved this to Accepted in 3.16.x Feb 27, 2025
@ramezsaeed ramezsaeed added this to the 2.8.0 milestone Feb 27, 2025
@ramezsaeed
Copy link
Contributor

ramezsaeed commented Feb 27, 2025

when the GPU toggle selected by the user, so we must check the node is rented before enable the deploy.

@0oM4R 0oM4R self-assigned this Feb 27, 2025
@0oM4R 0oM4R moved this from Accepted to In Progress in 3.16.x Feb 27, 2025
@0oM4R
Copy link
Contributor

0oM4R commented Feb 27, 2025

Work completed:

  • add validation on hasGPU
  • Move the validation if the node is rented to ValidateRentContract. This will allow us to deploy on dedicated nodes inside the shared farm and clarify the validation message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Small changes that can enhance the code/UI
Projects
Status: In Progress
Development

No branches or pull requests

3 participants