Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the statement of index query to be consistent with standard SQL #249

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Modify the statement of index query to be consistent with standard SQL #249

wants to merge 6 commits into from

Conversation

kr11
Copy link
Contributor

@kr11 kr11 commented Dec 28, 2017

  1. change involved code in query processing package.
  2. refine the test code of KVIndex.
  3. change involved lines of TSParser.g.
  4. Note that, Index query is conflict with Aggregation statement for the sake of LL principle(?). In this pull request, therefore, KVIndex is a constant. If we tend to add more index function in future, we have to change this part of Antlr grammar.

@MyXOF
Copy link
Collaborator

MyXOF commented Dec 29, 2017

QP部分需要针对index增加相应的单元测试

@kr11
Copy link
Contributor Author

kr11 commented Dec 29, 2017

@MyXOF test has been added.

@codecov
Copy link

codecov bot commented Jan 2, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@94af8f0). Click here to learn what that means.
The diff coverage is 71.15%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #249   +/-   ##
=========================================
  Coverage          ?   52.92%           
=========================================
  Files             ?      224           
  Lines             ?    26166           
  Branches          ?     7862           
=========================================
  Hits              ?    13849           
  Misses            ?    10749           
  Partials          ?     1568
Impacted Files Coverage Δ
...ghua/iotdb/index/common/IndexManagerException.java 0% <ø> (ø)
...edu/tsinghua/iotdb/index/kvmatch/KvMatchIndex.java 0% <ø> (ø)
.../java/cn/edu/tsinghua/iotdb/qp/QueryProcessor.java 95.77% <ø> (ø)
...ghua/iotdb/qp/logical/crud/IndexQueryOperator.java 0% <0%> (ø)
.../tsinghua/iotdb/qp/logical/crud/IndexOperator.java 100% <100%> (ø)
...ua/iotdb/qp/exception/QueryProcessorException.java 100% <100%> (ø)
...edu/tsinghua/iotdb/qp/physical/crud/IndexPlan.java 70.37% <100%> (ø)
...java/cn/edu/tsinghua/iotdb/index/IndexManager.java 36.36% <50%> (ø)
.../tsinghua/iotdb/qp/strategy/PhysicalGenerator.java 71.22% <66.66%> (ø)
...tdb/qp/strategy/optimizer/ConcatPathOptimizer.java 77.01% <69.23%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94af8f0...f725edd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kr11 @MyXOF