From 9dcc5c98cf8d812fdcd3625da05abe7c55d7163a Mon Sep 17 00:00:00 2001
From: rwood-moz <rwood@thunderbird.net>
Date: Mon, 9 Dec 2024 17:19:47 -0500
Subject: [PATCH] Add basic test for sign in/out

---
 frontend/src/views/LoginView.vue    |  8 +++--
 test/e2e/const/constants.ts         |  5 ++++
 test/e2e/pages/fxa-page.ts          | 15 ++++++++++
 test/e2e/pages/splashscreen-page.ts | 24 ++++++++++++++-
 test/e2e/tests/sign-in.spec.ts      | 46 +++++++++++++++++++++++++++++
 test/e2e/tests/sign-out.spec.ts     | 25 ++++++++++++++++
 6 files changed, 119 insertions(+), 4 deletions(-)
 create mode 100644 test/e2e/pages/fxa-page.ts
 create mode 100644 test/e2e/tests/sign-in.spec.ts
 create mode 100644 test/e2e/tests/sign-out.spec.ts

diff --git a/frontend/src/views/LoginView.vue b/frontend/src/views/LoginView.vue
index cbfa24053..07cf4b167 100644
--- a/frontend/src/views/LoginView.vue
+++ b/frontend/src/views/LoginView.vue
@@ -214,9 +214,9 @@ const onEnter = () => {
       </div>
       <div class="form-body">
         <form v-if="loginStep !== LoginSteps.SignUpConfirm" class="form" ref="formRef" autocomplete="off" @submit.prevent @keyup.enter="() => onEnter()">
-          <text-input name="email" v-model="email" :required="true">{{ t('login.form.email') }}</text-input>
-          <text-input v-if="isPasswordAuth" name="password" v-model="password" :required="true" type="password">{{ t('label.password') }}</text-input>
-          <text-input v-if="loginStep === LoginSteps.SignUp && !hideInviteField" name="inviteCode" v-model="inviteCode" :help="t('login.form.no-invite-code')">{{ t('label.inviteCode') }}</text-input>
+          <text-input name="email" v-model="email" :required="true" data-testid="login-email-input">{{ t('login.form.email') }}</text-input>
+          <text-input v-if="isPasswordAuth" name="password" v-model="password" :required="true" type="password" data-testid="login-password-input">{{ t('label.password') }}</text-input>
+          <text-input v-if="loginStep === LoginSteps.SignUp && !hideInviteField" name="inviteCode" v-model="inviteCode" :help="t('login.form.no-invite-code')" data-testid="login-invite-code-input">{{ t('label.inviteCode') }}</text-input>
         </form>
       </div>
       <template v-slot:actions>
@@ -226,6 +226,7 @@ const onEnter = () => {
           :disabled="isLoading"
           @click="onEnter()"
           v-if="loginStep !== LoginSteps.SignUpConfirm"
+          data-testid="login-continue-btn"
         >
           {{ t('label.continue') }}
         </primary-button>
@@ -235,6 +236,7 @@ const onEnter = () => {
           :disabled="isLoading"
           @click="router.push({name: 'home'})"
           v-else
+          data-testid="login-close-btn"
         >
           {{ t('label.close') }}
         </primary-button>
diff --git a/test/e2e/const/constants.ts b/test/e2e/const/constants.ts
index 10e17924d..5cc6f9026 100644
--- a/test/e2e/const/constants.ts
+++ b/test/e2e/const/constants.ts
@@ -3,3 +3,8 @@ export const APPT_PROD_URL = 'https://appointment.day/';
 
 // page titles
 export const APPT_PAGE_TITLE = 'Thunderbird Appointment';
+export const FXA_PAGE_TITLE = 'Mozilla accounts';
+
+// production sign-in credentials
+export const PROD_LOGIN_EMAIL = process.env.APPT_PROD_LOGIN_EMAIL;
+export const PROD_LOGIN_PWORD = process.env.APPT_PROD_LOGIN_PWORD;
diff --git a/test/e2e/pages/fxa-page.ts b/test/e2e/pages/fxa-page.ts
new file mode 100644
index 000000000..60ca87a7e
--- /dev/null
+++ b/test/e2e/pages/fxa-page.ts
@@ -0,0 +1,15 @@
+import { type Page, type Locator } from '@playwright/test';
+
+export class FxAPage {
+  readonly page: Page;
+  readonly signInHeaderText: Locator;
+  readonly userAvatar: Locator;
+  readonly signInButton: Locator;
+
+  constructor(page: Page) {
+    this.page = page;
+    this.signInHeaderText = this.page.getByText('Enter your password');
+    this.userAvatar = this.page.getByTestId('avatar-default');
+    this.signInButton = this.page.locator('button:text("Sign in")');
+  }
+}
diff --git a/test/e2e/pages/splashscreen-page.ts b/test/e2e/pages/splashscreen-page.ts
index 6ad2cffd3..63422c819 100644
--- a/test/e2e/pages/splashscreen-page.ts
+++ b/test/e2e/pages/splashscreen-page.ts
@@ -5,14 +5,36 @@ export class SplashscreenPage {
   readonly page: Page;
   readonly loginBtn: Locator;
   readonly signUpBetaBtn: Locator;
+  readonly loginEmailInput: Locator;
+  readonly loginContinueBtn: Locator;
 
   constructor(page: Page) {
     this.page = page;
-    this.loginBtn = this.page.getByTestId('home-login-btn');
+    //update this after data-testid 's are deployed to prod
+    //this.loginBtn = this.page.getByTestId('home-login-btn');
+    this.loginBtn = this.page.getByTitle('Log in');
     this.signUpBetaBtn = this.page.getByTestId('home-sign-up-beta-btn');
+    //update this after data-testid 's are deployed to prod
+    //this.loginEmailInput = this.page.getByTestId('login-email-input');
+    this.loginEmailInput = this.page.getByLabel('Email address');
+    //update this after data-testid 's are deployed to prod    
+    //this.loginContinueBtn = this.page.getByTestId('login-continue-btn');
+    this.loginContinueBtn = this.page.getByTitle('Continue');
   }
 
   async gotoProd() {
     await this.page.goto(APPT_PROD_URL);
   }
+
+  async clickLoginBtn() {
+    await this.loginBtn.click();
+  }
+
+  async clickLoginContinueBtn() {
+    await this.loginContinueBtn.click();
+  }
+
+  async enterLoginEmail(emailAddress: string) {
+    await this.loginEmailInput.fill(emailAddress);
+  }
 }
diff --git a/test/e2e/tests/sign-in.spec.ts b/test/e2e/tests/sign-in.spec.ts
new file mode 100644
index 000000000..968ee7641
--- /dev/null
+++ b/test/e2e/tests/sign-in.spec.ts
@@ -0,0 +1,46 @@
+import { test, expect } from '@playwright/test';
+import { SplashscreenPage } from '../pages/splashscreen-page';
+import { FxAPage } from '../pages/fxa-page';
+import { PROD_LOGIN_EMAIL, FXA_PAGE_TITLE } from '../const/constants';
+
+let splashscreen: SplashscreenPage;
+let fxa_sign_in: FxAPage;
+
+test.beforeEach(async ({ page }) => {
+  // navigate to the main appointment page (splashscreen)
+  splashscreen = new SplashscreenPage(page);
+  fxa_sign_in = new FxAPage(page);
+  await splashscreen.gotoProd();
+});
+
+// verify basic sign-in flow works
+test.describe('basic sign-in flow', {
+  tag: '@prod-sanity'
+}, () => {
+  test('clicking login button brings up the sign-in dialog', async ({ page }) => {
+    await expect(splashscreen.loginBtn).toBeVisible();
+    await splashscreen.clickLoginBtn();
+    await expect(splashscreen.loginEmailInput).toBeVisible();
+    await expect(splashscreen.loginContinueBtn).toBeVisible();
+  });
+
+  test('clicking continue button on login dialog brings up the FxA sign-in dialog', async ({ page }) => {
+    await expect(splashscreen.loginBtn).toBeVisible();
+    await splashscreen.clickLoginBtn();
+    expect(PROD_LOGIN_EMAIL, 'getting APPT_PROD_LOGIN_EMAIL env var').toBeTruthy();
+    await splashscreen.enterLoginEmail(String(PROD_LOGIN_EMAIL))
+    await splashscreen.clickLoginContinueBtn();
+    await expect(page).toHaveTitle(FXA_PAGE_TITLE);
+    await expect(fxa_sign_in.signInHeaderText).toBeVisible({ timeout: 30_000 }); // be generous in case FxA is slow to load
+    await expect(fxa_sign_in.userAvatar).toBeVisible();
+    await expect(fxa_sign_in.signInButton).toBeVisible();
+  });
+
+  // todo fill out sign-in dialog etc. use the splashscreen-page object model is fine
+  test('able to sign-in to appointment', async ({ page }) => {
+    // todo fill out email address field, password field, and click continue button
+    //      => use credentials set via local env vars (will set via secrets in CI)
+    // add a splashscreen.signOut() and use that; then verify here (dashbaord appears)
+    expect(true).toBeTruthy();
+  });
+});
diff --git a/test/e2e/tests/sign-out.spec.ts b/test/e2e/tests/sign-out.spec.ts
new file mode 100644
index 000000000..ee07e3cec
--- /dev/null
+++ b/test/e2e/tests/sign-out.spec.ts
@@ -0,0 +1,25 @@
+import { test, expect } from '@playwright/test';
+import { SplashscreenPage } from '../pages/splashscreen-page';
+import { APPT_PAGE_TITLE } from '../const/constants';
+
+let splashscreen: SplashscreenPage;
+
+test.beforeEach(async ({ page }) => {
+  // navigate to the main appointment page (splashscreen)
+  splashscreen = new SplashscreenPage(page);
+  await splashscreen.gotoProd();
+  // todo fill out email address field, password field, and click continue button
+  //      => use credentials set via local env vars (will set via secrets in CI)
+  // then verifiy sign-in was successful - dashboard appears
+  // use splashscreen-page signOn() method
+});
+
+// verify main appointment splash screen appears correctly
+test.describe('basic sign-out flow', {
+  tag: '@prod-sanity'
+}, () => {
+  test('able to sign-out of appointment', async ({ page }) => {
+    // todo sign out and verify splashscreen appears with login button visible
+    expect(true).toBeTruthy();
+  });
+});