Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show API errors in frontend #172

Open
devmount opened this issue Nov 15, 2023 · 2 comments
Open

Show API errors in frontend #172

devmount opened this issue Nov 15, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request M: Appointment MVP UI / UX Related to user interface or user experience
Milestone

Comments

@devmount
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
If the backend API throws an error (like 401, 403 or similar) those are currently not shown in the frontend (with a few exceptions I think).

Describe the solution you'd like
Use a frontend notification component to show error messages from backend to the current user, if it makes sense for the use case (e.g. the reason why appointment creation failed).

Additional context
https://github.com/thunderbird/appointment/pull/170/files?diff=unified&w=1#r1393343082

@devmount devmount added the enhancement New feature or request label Nov 15, 2023
@devmount devmount added this to the v0.2 milestone Nov 16, 2023
@MelissaAutumn MelissaAutumn added the UI / UX Related to user interface or user experience label Jan 9, 2024
@MelissaAutumn
Copy link
Member

@solangevalverde I can't find any designs that allow for a prettied up dump of red text on various forms. Can you take a look at this when you get a chance? This can technically occur anywhere we have a save or update button, but most notably during "Create new appointment", "Edit calendar" and "Account settings" flows.

Examples of errors can be found under the "Exceptions" section of the ftl file: https://github.com/thunderbird/appointment/blob/main/backend/src/appointment/l10n/en/main.ftl#L11

@MelissaAutumn MelissaAutumn self-assigned this Feb 7, 2024
@MelissaAutumn
Copy link
Member

I'm going to do an initial ugly pass on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request M: Appointment MVP UI / UX Related to user interface or user experience
Projects
None yet
Development

No branches or pull requests

3 participants